HostUtils: parseAlias: allow hostnames without tld#15102
Open
asavageiv wants to merge 1 commit intoCollaboraOnline:mainfrom
Open
HostUtils: parseAlias: allow hostnames without tld#15102asavageiv wants to merge 1 commit intoCollaboraOnline:mainfrom
asavageiv wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
Author
|
@meven PTAL and let me know if there are any more tests I should add |
Contributor
|
I made a PR too, but yours is more complete. |
6 tasks
Contributor
|
I like much better my commit message: Cool is a big project, it is better to add some context to your commit title i.e first line |
Fixes CollaboraOnline/issues/15100 Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com> Change-Id: I2bacc4caf1affed090845178c72ecd39bb0cfa91
asavageiv
force-pushed
the
asavage/fix-parseAlias
branch
from
2e7b83d to
5ad236f
Compare
asavageiv
changed the title
Author
|
Yeah, yours is way better. TY for the quick review! |
meven
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes /issues/15100
Change-Id: I2bacc4caf1affed090845178c72ecd39bb0cfa91
Summary
Fix HostUtil::parseAlias to accept hostnames with a single segment, e.g. http://test as opposed to http://test.local
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay