Marked some buttons as dialog buttons#15108
Open
misespuneraul wants to merge 1 commit intoCollaboraOnline:mainfrom
Open
Marked some buttons as dialog buttons#15108misespuneraul wants to merge 1 commit intoCollaboraOnline:mainfrom
misespuneraul wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
Author
|
There's also the case of File > "Export As" and Design > "Background Image". I'm not sure if those should read out "opens dialog" as well, opinions would be appreciated |
Signed-off-by: Raul-Ionut Nastasie <raul-ionut.nastasie@collabora.com> Change-Id: I58f84e3bec5e6ef51cf9f68088a956c31508d5c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I58f84e3bec5e6ef51cf9f68088a956c31508d5c5
Summary
Properly marked some buttons as dialog buttons to later get aria-haspopup="dialog" for the screen reader. Repair button doesn't seem to get the tag even if the command it sends is .uno:DocumentRepair
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay