browser: a11y: fix Tab key navigation in multiline edit#15132
Open
hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
Open
browser: a11y: fix Tab key navigation in multiline edit#15132hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
The multiline edit widget is supposed to send the 'selection' command to the server if and only if there is an actual text selection. Currently, every navigation key (even those only changing focus) triggers the command, causing the server to react and hide elements in dialogs (e.g., in the Formula Wizard Dialog). Change-Id: I6049ec4bc4ed794b7f0672586f5c31757c2e005a Signed-off-by: Henry Castro <hcastro@collabora.com>
caolanm
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiline edit widget is supposed to send the 'selection' command
to the server if and only if there is an actual text selection.
Currently, every navigation key (even those only changing focus)
triggers the command, causing the server to react and hide elements in
dialogs (e.g., in the Formula Wizard Dialog).
Change-Id: I6049ec4bc4ed794b7f0672586f5c31757c2e005a
Signed-off-by: Henry Castro hcastro@collabora.com