Merge dev into master for v1.1.0 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated package.json to change the main entry point from `src/extension.js` to `dist/extension.js`. - Enhanced the configuration options for responsive image sizes and paths. - Added TypeScript support with a new tsconfig.json file. - Replaced the JavaScript implementation in `src/extension.js` with TypeScript in `src/extension.ts`. - Modularized the code by separating commands, prompts, images, and provider functionalities into their respective files. - Implemented TypeScript types for better type safety and code clarity. - Removed the old JavaScript files and replaced them with compiled TypeScript files in the `dist` directory. - Updated ESLint configuration to support ES2022 features and TypeScript.
… improvements, and updated changelog - Added new explorer context menu for image files.
…er project structure
fix: improve error handling in commands and image processing - Changed error handling to use `unknown` type for better type safety - Updated error messages to ensure consistent formatting refactor: clean up unused imports and improve code readability - Removed unnecessary imports in extension.ts and provider.ts - Simplified variable declarations in commands.ts chore: add ESLint configuration for TypeScript and JavaScript - Introduced eslint.config.mts for better linting support - Updated ESLint and TypeScript dependencies in package.json
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the extension from JavaScript to TypeScript, introducing a modular architecture that improves code maintainability and type safety. The refactor splits the monolithic extension.js file into focused modules (commands.ts, prompts.ts, images.ts, provider.ts) while adding new UI features including context menu integration and editor title bar actions for generating responsive images directly from image files.
Key changes:
- Complete TypeScript migration with modular file structure
- New context menu options for explorer and editor title bar
- Enhanced error handling and reporting throughout the codebase
Reviewed Changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension.ts | New TypeScript entry point replacing the monolithic JavaScript file |
| src/commands.ts | Extracted command registration and logic with improved error handling |
| src/prompts.ts | Isolated user prompt functions for inputs (files, directories, sizes) |
| src/images.ts | Dedicated module for image processing with structured error tracking |
| src/provider.ts | Separated completion provider logic with dynamic language support |
| package.json | Updated for TypeScript build, added context menus, icons, and new dependencies |
| eslint.config.mts | Modern TypeScript-aware ESLint configuration |
| src/extension.js, extension.js | Removed legacy JavaScript implementation files |
| config/eslint.config.mjs, config/jsconfig.json | Removed outdated configuration files |
| CHANGELOG.md | Documented v1.1.0 changes and features |
| TODO.md | Added tracking for planned improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements and refactoring to the "responsive-image-generator" extension, focusing on code maintainability, user experience enhancements, and better project structure. The extension now features a modular TypeScript codebase, new UI integrations, improved error handling, and updated documentation. Below are the key changes grouped by theme:
Major Refactor and Codebase Improvements:
Migrated the main extension logic from a monolithic
extension.jsfile to a modular TypeScript structure, introducing new files such assrc/commands.tsfor command registration and logic. This enhances maintainability and paves the way for future features. [1] [2]Replaced and improved ESLint configuration, removing legacy config files (
config/eslint.config.mjs,config/jsconfig.json) and adding a modern TypeScript-aware ESLint setup (eslint.config.mts). [1] [2] [3]User Experience and UI Enhancements:
Added new context menu options: users can now generate responsive images directly from the explorer (right-click on image files) and from the editor title bar, streamlining the workflow.
Added extension icons for both light and dark themes, and updated the command palette with categorized and icon-enhanced entries for better discoverability. [1] [2]
Functionality and Error Handling:
Improved error handling throughout the extension, especially in image processing commands, with detailed error messages for failed operations.
Updated the command registration to support invoking the generator from context menus and editor actions, passing the relevant resource URI when available. [1] [2]
Documentation and Project Management:
CHANGELOG.mdto document new features and enhancements, and introduced aTODO.mdfile to track planned improvements and outstanding tasks. [1] [2]Build and Dependency Updates:
package.jsonto reflect the new version (1.1.0), added TypeScript and new dev dependencies, improved build scripts, and set the main entry point to the compiled output. [1] [2] [3]These changes collectively modernize the extension's codebase, improve its usability, and lay the groundwork for future enhancements.