Conversation
redeboer
force-pushed
the
ENH/export-aliases
branch
from
58f1564 to
64ae148
Compare
redeboer
force-pushed
the
ENH/export-aliases
branch
from
64ae148 to
a7883cc
Compare
There was a problem hiding this comment.
PR Overview
This PR exports additional cached aliases to avoid private import usage linting errors.
- Updates docs/conf.py to include the "Model" alias and add it to the nitpick ignore list.
- Expands src/ampform_dpd/io/cached.py with new imports and all exports for caching functions, including simplify, subs, trigsimp, and lambdify.
Reviewed Changes
| File | Description |
|---|---|
| docs/conf.py | Added the "Model" alias and corresponding nitpick ignore entry to suppress linting errors. |
| src/ampform_dpd/io/cached.py | Updated the import statement to include additional cached functions and revised the all export list accordingly. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/ampform_dpd/io/cached.py:24
- [nitpick] Consider reordering the all list to align with the import order or sort it alphabetically to improve consistency.
__all__ = [
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ampform_dpd.io.cachedaliases toampform.sympy.cachedare now exported through__all__to avoidreportPrivateImportUsagelinting errors.