Skip to content

BREAK: remove P and Q classes#170

Merged
redeboer merged 7 commits intomainfrom
remove_Q
Oct 10, 2025
Merged

BREAK: remove P and Q classes#170
redeboer merged 7 commits intomainfrom
remove_Q

Conversation

@Zeyna777
Copy link
Copy Markdown
Contributor

@Zeyna777 Zeyna777 commented Oct 6, 2025

Closes #169

@Zeyna777 Zeyna777 requested a review from redeboer October 6, 2025 15:21
@Zeyna777 Zeyna777 self-assigned this Oct 6, 2025
@Zeyna777 Zeyna777 added ⚙️ Enhancement Improvements and optimizations of existing features ⚠️ Interface Breaking changes to the API labels Oct 6, 2025
@redeboer redeboer changed the title ENH: remove Q class BREAK: remove P and Q classes Oct 6, 2025
@redeboer redeboer marked this pull request as draft October 6, 2025 15:24
@redeboer redeboer removed the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 6, 2025
@redeboer redeboer added this to the 0.2.4 milestone Oct 6, 2025
@redeboer
Copy link
Copy Markdown
Member

redeboer commented Oct 9, 2025

New implementation is being tested in ComPWA/polarimetry#426. It results only in slight changes of the numerical values of the amplitude model.

@redeboer redeboer marked this pull request as ready for review October 10, 2025 10:15
Copy link
Copy Markdown
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 🌮 See ComPWA/polarimetry#426

@redeboer redeboer merged commit 8ca6761 into main Oct 10, 2025
30 checks passed
@redeboer redeboer deleted the remove_Q branch October 10, 2025 10:17
redeboer pushed a commit that referenced this pull request Oct 27, 2025
* MAINT: upgrade AmpForm
* MAINT: update expression hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Interface Breaking changes to the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace P and Q classes with AmpForm's BreakupMomentum

2 participants