Skip to content

ENH: convert to sp.Symbol before computing unfold hash#465

Merged
redeboer merged 13 commits intoComPWA:mainfrom
redeboer:FIX/substitute-Indexed
Mar 6, 2025
Merged

ENH: convert to sp.Symbol before computing unfold hash#465
redeboer merged 13 commits intoComPWA:mainfrom
redeboer:FIX/substitute-Indexed

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Mar 6, 2025

This stabilizes the hash of amplitude models that contain sympy.Indexed symbols.

Warning

The hashes are still not fully stable!

@redeboer redeboer added this to the 0.15.7 milestone Mar 6, 2025
@redeboer redeboer self-assigned this Mar 6, 2025
@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Mar 6, 2025
@redeboer redeboer marked this pull request as ready for review March 6, 2025 20:06
@redeboer redeboer merged commit e848487 into ComPWA:main Mar 6, 2025
32 checks passed
@redeboer redeboer deleted the FIX/substitute-Indexed branch March 6, 2025 20:08
redeboer added a commit that referenced this pull request Mar 7, 2025
This reverts the implementation of #465 (but not the tests)
redeboer added a commit that referenced this pull request Mar 7, 2025
This reverts the implementation of #465 (but not the tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ Enhancement Improvements and optimizations of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant