Skip to content

chore(js): bump nodejs from 18.20.6 to latest LTS 22.14#2328

Merged
PiTrem merged 6 commits intomainfrom
chore_nodejs_22
Feb 27, 2025
Merged

chore(js): bump nodejs from 18.20.6 to latest LTS 22.14#2328
PiTrem merged 6 commits intomainfrom
chore_nodejs_22

Conversation

@PiTrem
Copy link
Member

@PiTrem PiTrem commented Feb 11, 2025

chore(js): bump nodejs from 18.20.6 to latest LTS 22.14.0

  • set engine accordingly
  • js test setup and specs updated to work properly

JS test updates

  • build: change factory-bot npm package to eflexsystems/factory-bot

  • style: js absolute import with alias in spec/javascripts

  • JSX to createElement and skip outdated/broken test:

    • replace JSX to React.createElement
    • fix import of default exported constants
    • rm unecessary async
    • mv outdated logic like instance() or state() on functional component into the it block
    • skip test using xit or skip
  • setup

    • navigator fix: Cannot set property navigator of #<Object> which has only a getter
    • require jsdom-global for testing components that rely on Quill and rm mocked components to avoid error

Exception during run: ReferenceError: Node is not defined at Object.<anonymous> (/home/chemotion-dev/app/node_modules/quill/dist/quill.js:8899:26

JS package libraries change

replaced

  • dev-dep for js test:
    replaced factory-bot@^6.3.1 by @eflexsystems/factory-bot@^9.0.0

added

  • module alias (>nodejs20) for absolute import module-alias@^2.2.3
  • dev-dep for testing add jsdom-global"@3.0.2

@PiTrem PiTrem marked this pull request as draft February 11, 2025 13:10
@PiTrem PiTrem changed the title chore(js): bump nodejs from 18.20.6 to latest LTS 22.13.1 chore(js): bump nodejs from 18.20.6 to latest LTS 22.14 Feb 21, 2025
@github-actions
Copy link

LCOV of commit fb19aaa during Continuous Integration #4532

Summary coverage rate:
  lines......: 67.1% (15507 of 23121 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem marked this pull request as ready for review February 27, 2025 15:02
@github-actions
Copy link

LCOV of commit 1aa7362 during Continuous Integration #4533

Summary coverage rate:
  lines......: 67.0% (15490 of 23122 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit 6c7abca during Continuous Integration #4536

Summary coverage rate:
  lines......: 67.0% (15491 of 23121 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

for testing components that rely on Quill

avoid error:
Exception during run: ReferenceError: Node is not defined
    at Object.<anonymous> (/home/chemotion-dev/app/node_modules/quill/dist/quill.js:8899:26
- replace JSX to React.createElement
- fix import of default exported constants
- rm unecessary async
- mv outdated logic like instance() or state() on functional component
  into the it block
- skip test using xit or skip

style(js): eslint common.spec.js
@github-actions
Copy link

LCOV of commit 760ce12 during Continuous Integration #4537

Summary coverage rate:
  lines......: 67.0% (15491 of 23121 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit a08ecb7 into main Feb 27, 2025
4 checks passed
PiTrem pushed a commit that referenced this pull request Aug 13, 2025
js test configuration file setup.js was moved up one directory level 

ref: #2328
PiTrem pushed a commit that referenced this pull request Aug 13, 2025
js test configuration file setup.js was moved up one directory level 

ref: #2328
haditariq pushed a commit that referenced this pull request Aug 19, 2025
js test configuration file setup.js was moved up one directory level 

ref: #2328
PiTrem pushed a commit that referenced this pull request Aug 21, 2025
js test configuration file setup.js was moved up one directory level 

ref: #2328
Nicolass67 pushed a commit that referenced this pull request Oct 29, 2025
js test configuration file setup.js was moved up one directory level 

ref: #2328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants