ci(test): simplify db setup for github action#2365
Merged
Conversation
PiTrem
force-pushed
the
ci_update_db_setup
branch
from
7ff02bd to
14952ce
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
config/initializers/eln_features.rb
Outdated
| ).first | ||
| puts "Warning: PG cartridge #{cartridge} version #{cartridge_version} is not installed" unless cartridge_present | ||
| end | ||
| rescue PG::ConnectionBad, ActiveRecord::NoDatabaseError => e |
There was a problem hiding this comment.
Lint/SuppressedException: Do not suppress exceptions.
Merged
PiTrem
force-pushed
the
ci_update_db_setup
branch
3 times, most recently
from
5901ba5 to
27f3b4a
Compare
PiTrem
force-pushed
the
ci_update_db_setup
branch
from
27f3b4a to
3040607
Compare
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use superuser postgres as role for setting up the test db
so that 'create extension' can be run without permission issue
rm unused template database.yml