Skip to content

Conversation

@alizaib1217
Copy link
Contributor

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

LCOV of commit 2dff0f8 during CI - Ruby Lint, RSpec, and code coverage #186

Summary coverage rate:
  lines......: 66.2% (16705 of 25237 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@alizaib1217 alizaib1217 self-assigned this Nov 4, 2025
fixed cors error

fixed credential cors error
@alizaib1217 alizaib1217 force-pushed the feat/allow-CORS-for-collection-import branch from 37f687a to fd1825c Compare November 4, 2025 14:38
@alizaib1217 alizaib1217 changed the title Feat/allow cors for collection import chore/allow cors for collection import Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

LCOV of commit 37f687a during CI - Ruby Lint, RSpec, and code coverage #187

Summary coverage rate:
  lines......: 66.2% (16705 of 25237 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

LCOV of commit fd1825c during CI - Ruby Lint, RSpec, and code coverage #188

Summary coverage rate:
  lines......: 66.2% (16704 of 25238 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@alizaib1217 alizaib1217 requested a review from phuang26 November 5, 2025 10:02
@alizaib1217 alizaib1217 marked this pull request as ready for review November 5, 2025 11:38
@alizaib1217 alizaib1217 marked this pull request as draft November 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant