Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/chemotion/svg_sanitizer.rb
Outdated
| end | ||
| end | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
Layout/TrailingEmptyLines: Final newline missing.
haditariq
changed the title
spec/lib/chemotion/sanitizer_spec.rb
Outdated
| end | ||
| # rubocop:enable RSpec/MultipleMemoizedHelpers | ||
| # rubocop:enable Rspec/IndexedLet | ||
| # rubocop:enable Rspec/IndexedLet No newline at end of file |
There was a problem hiding this comment.
Layout/TrailingEmptyLines: Final newline missing.
LCOV of commit
|
haditariq
force-pushed
the
bugfix_v2-ketcher-display-issue-with-tools
branch
from
cd76a1a to
3d6e2a5
Compare
LCOV of commit
|
rubocop draft: yarn nodejs tool rspec: svg_sanitizer rubo extra file chore: v2 base files
haditariq
force-pushed
the
bugfix_v2-ketcher-display-issue-with-tools
branch
from
24f7cf8 to
a117af6
Compare
LCOV of commit
|
PiTrem
changed the title
PiTrem
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #2582 to v2.x
1- SVG conflicting ID's suffix limited to glyphs
2- Loofah scrub removing SVG elements from the SVG
3- Ketcher API fails to generate SVG, does not affect saving in the editor
HOW
1- More dynamic glyph IDs
2- Custom SVG+HTML tag sanitizer using nokogiri
3- If Ketcher is not able to generate an SVG for the structure, give user feedback that SVG generation failed