feat(UI): Restructure application header#2974
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| device_description: Entities::DeviceDescriptionEntity.represent( | ||
| device_description, | ||
| detail_levels: ElementDetailLevelCalculator.new(user: current_user, element: device_description) | ||
| .detail_levels, |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Align .detail_levels with ElementDetailLevelCalculator.new(user: current_user, element: device_description) on line 130.
| detail_levels: ElementDetailLevelCalculator.new(user: current_user, element: device_description) | ||
| .detail_levels, | ||
| policy: @element_policy, | ||
| ) |
There was a problem hiding this comment.
Style/TrailingCommaInHashLiteral: Put a comma after the last item of a multiline hash.
| Entities::DeviceDescriptionEntity.represent( | ||
| device_description, | ||
| displayed_in_list: true, | ||
| detail_levels: ElementDetailLevelCalculator.new(user: current_user, element: device_description).detail_levels, |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [125/120]
app/api/chemotion/sample_api.rb
Outdated
| element_policy = ElementPolicy.new(current_user, sample) | ||
| sample_list.push( | ||
| Entities::SampleEntity.represent(sample, detail_levels: detail_levels, displayed_in_list: true), | ||
| Entities::SampleEntity.represent(sample, detail_levels: detail_levels, displayed_in_list: true, policy: element_policy), |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [136/120]
app/api/chemotion/sample_api.rb
Outdated
| element_policy = ElementPolicy.new(current_user, sample) | ||
| sample_list.push( | ||
| Entities::SampleEntity.represent(sample, detail_levels: detail_levels, displayed_in_list: true), | ||
| Entities::SampleEntity.represent(sample, detail_levels: detail_levels, displayed_in_list: true, policy: element_policy), |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [134/120]
…e the application
…copying Fix can_copy permission inconsistency between list and detail views - Add ElementPolicy to API list endpoints (DeviceDescription, SequenceBasedMacromolecule, CellLine) to provide proper permission context for can_copy evaluation - Remove `unless: :displayed_in_list` conditions from entity can_copy exposure to ensure field availability in list serialization - Implement complete can_copy functionality for CellLines by adding ElementPolicy to all CellLineAPI endpoints and updating frontend model extraction
…n CellLine Details intact.
JoachimTillessen
force-pushed
the
Restructure-application-header
branch
from
5c1f7b3 to
c0766dd
Compare
LCOV of commit
|
PiTrem
changed the title
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
Contributor
|
it seems that some refactoring in this PR makes MessagesFetcher.configuration() is bombarding the server with requests, can you check? |
adambasha0
reviewed
Mar 2, 2026
app/javascript/src/apps/mydb/mainNavigation/topbar/NoticeButton.js
Outdated
Show resolved
Hide resolved
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
LCOV of commit
|
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release