Skip to content

feat(Parameters): Dump integers with type attribute#64

Open
Hipska wants to merge 1 commit intoCombodo:masterfrom
Super-Visions:feature/parameters/type_dump
Open

feat(Parameters): Dump integers with type attribute#64
Hipska wants to merge 1 commit intoCombodo:masterfrom
Super-Visions:feature/parameters/type_dump

Conversation

@Hipska
Copy link
Collaborator

@Hipska Hipska commented Dec 11, 2025

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N/A
Type of change? Enhancement

Objective

The dump should keep/store the type attributes from the original parameters file.

Proposed solution

Add type="int" attribute when the value is an integer.

Checklist before requesting a review

  • I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

@jf-cbd
Copy link
Member

jf-cbd commented Feb 27, 2026

Sounds good, but could you please indicate us the consequences (for the user) of not having a dump that contains the type when the value is an integer ?

@Hipska
Copy link
Collaborator Author

Hipska commented Feb 27, 2026

No consequence for the user, but if collector provides a file with an int option, it will keep the same format when dumped. Also see #63 where I'm intending to add support for other value types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: First review needed

Development

Successfully merging this pull request may close these issues.

3 participants