feat(Parameters): Dump integers with type attribute#64
Open
Hipska wants to merge 1 commit intoCombodo:masterfrom
Open
feat(Parameters): Dump integers with type attribute#64Hipska wants to merge 1 commit intoCombodo:masterfrom
Hipska wants to merge 1 commit intoCombodo:masterfrom
Conversation
Member
|
Sounds good, but could you please indicate us the consequences (for the user) of not having a dump that contains the type when the value is an integer ? |
Collaborator
Author
|
No consequence for the user, but if collector provides a file with an int option, it will keep the same format when dumped. Also see #63 where I'm intending to add support for other value types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Objective
The dump should keep/store the type attributes from the original parameters file.
Proposed solution
Add
type="int"attribute when the value is an integer.Checklist before requesting a review