Skip to content

fix(Orchestrator): Gracefully catch exceptions from Synchronize step#68

Open
Hipska wants to merge 1 commit intoCombodo:masterfrom
Super-Visions:fix/orchestrator/synchronize
Open

fix(Orchestrator): Gracefully catch exceptions from Synchronize step#68
Hipska wants to merge 1 commit intoCombodo:masterfrom
Super-Visions:fix/orchestrator/synchronize

Conversation

@Hipska
Copy link
Collaborator

@Hipska Hipska commented Jan 9, 2026

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N/A
Type of change? Bug fix

Symptom

When one of the collectors throws an exception, the complete synchronisation process will stop even when stop_on_synchro_error is disabled.

Reproduction procedure

  1. Have a collector that throws an exception during its synchronisation process (DoProcessBeforeSynchro)
  2. Run synchro.

Cause

Exception thrown by Collector::Synchronize aren't catched inside Orchestrator::Synchronize.

Proposed solution

Catch exception thrown by Collector::Synchronize inside Orchestrator::Synchronize and log its message before continuing to the next collector.

Checklist before requesting a review

  • I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: First review needed

Development

Successfully merging this pull request may close these issues.

2 participants