fix(Orchestrator): Gracefully catch exceptions from Synchronize step#68
Open
Hipska wants to merge 1 commit intoCombodo:masterfrom
Open
fix(Orchestrator): Gracefully catch exceptions from Synchronize step#68Hipska wants to merge 1 commit intoCombodo:masterfrom
Hipska wants to merge 1 commit intoCombodo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom
When one of the collectors throws an exception, the complete synchronisation process will stop even when
stop_on_synchro_erroris disabled.Reproduction procedure
DoProcessBeforeSynchro)Cause
Exception thrown by
Collector::Synchronizearen't catched insideOrchestrator::Synchronize.Proposed solution
Catch exception thrown by
Collector::SynchronizeinsideOrchestrator::Synchronizeand log its message before continuing to the next collector.Checklist before requesting a review