Enhance logger to format message with placeholders#69
Open
Enhance logger to format message with placeholders#69
Conversation
…rs (especially hidden ones)
Hipska
approved these changes
Feb 27, 2026
Collaborator
Hipska
left a comment
There was a problem hiding this comment.
I simple used sprintf before, but I'm fine with this as well..
This reverts commit 07051da.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After struggling with a CSV collector that had hidden hideous '\uFEFF' invible char in header line, I decided to propose below enhancements (I could have spared so much time and energy)
enhancing logging mechanism with placeholders
Example:
Utils::Log(LOG_WARNING, "Invalid columns '%1\$s' '%2\$s' '%3\$s'.", "primary_key", "colA", "colB");using this new behaviour in some collect/synchro strategical places to help collector users detects special chars issues.
Example: use a CSV collector with below line
\uFEFFprimary_key,name,lastname,whatever 123,john,does,yesOutput TODAY:
[WARNING] Invalid column 'primary_key', will be ignored. [ERROR] Failed to import the dataOutput with PR:
[WARNING] Invalid column '\uFEFFprimary_key', will be ignored. [ERROR] Failed to import the data