fix drive collection using partial scrape and getAllDriveEndpoints func

[ibrahimkk-moideen]

fix drive collection when "--collector.drives.modules-exclude" flag is not provided - complete

drive collection not happening with partial scrapes - fix in progress

[ibrahimkk-moideen]

Validation results:

Running without "collector.drives.modules-exclude" flag

1. complete scrape with truncated output only for drives & storage controller

curl -s 'http://localhost:10023/scrape?target=yourhost.yourdomain.com&model=dl380' | egrep 'drive|controller'
# HELP redfish_disk_drive_status Current Disk Drive status 1 = OK, 0 = BAD, -1 = DISABLED
# TYPE redfish_disk_drive_status gauge
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="0",location="1I:2:1",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="0",location="1I:3:1",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="1",location="1I:2:2",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
# HELP redfish_logical_drive_status Current Logical Drive Raid 1 = OK, 0 = BAD, -1 = DISABLED
# TYPE redfish_logical_drive_status gauge
redfish_logical_drive_status{capacityMiB="457830",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",logicaldrivename="xxxxxxxxx",name="HpeSmartStorageLogicalDrive",raid="1",volumeuniqueidentifier="xxxxxxxxx"} 1
# HELP redfish_storage_controller_status Current storage controller status 1 = OK, 0 = BAD
# TYPE redfish_storage_controller_status gauge
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 0",model="HPE Smart Array P408i-a SR Gen10",name="Hpe Smart Storage Array Controller"} 1
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 1",model="HPE Smart Array P408i-p SR Gen10",name="Hpe Smart Storage Array Controller"} 1
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 2",model="HPE Smart Array P408i-p SR Gen10",name="Hpe Smart Storage Array Controller"} 1

2. Partial scrape with components drives & storage controller

curl -s 'http://localhost:10023/scrape/partial?target=yourhost.yourdomain.com&model=dl380&components=drives,storage_controller'
# HELP redfish_disk_drive_status Current Disk Drive status 1 = OK, 0 = BAD, -1 = DISABLED
# TYPE redfish_disk_drive_status gauge
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="0",location="1I:2:1",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="0",location="1I:3:1",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
redfish_disk_drive_status{capacityMiB="3052360",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",failurePredicted="false",id="1",location="1I:2:2",name="HpeSmartStorageDiskDrive",serialnumber="xxxxxxxxx"} 1
# HELP redfish_logical_drive_status Current Logical Drive Raid 1 = OK, 0 = BAD, -1 = DISABLED
# TYPE redfish_logical_drive_status gauge
redfish_logical_drive_status{capacityMiB="457830",chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",logicaldrivename="xxxxxxxxx",name="HpeSmartStorageLogicalDrive",raid="1",volumeuniqueidentifier="xxxxxxxxx"} 1
# HELP redfish_storage_controller_status Current storage controller status 1 = OK, 0 = BAD
# TYPE redfish_storage_controller_status gauge
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 0",model="HPE Smart Array P408i-a SR Gen10",name="Hpe Smart Storage Array Controller"} 1
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 1",model="HPE Smart Array P408i-p SR Gen10",name="Hpe Smart Storage Array Controller"} 1
redfish_storage_controller_status{chassisModel="dl380",chassisSerialNumber="xxxxxxxxx",firmwareVersion="5.00",location="Slot 2",model="HPE Smart Array P408i-p SR Gen10",name="Hpe Smart Storage Array Controller"} 1
# HELP redfish_up was the last scrape of fishymetrics successful.
# TYPE redfish_up gauge
redfish_up 1

[ibrahimkk-moideen]

Go Test results:

PASS
ok  	github.com/comcast/fishymetrics/exporter	0.729s

[derrick-dacosta]

LGTM