Skip to content

Conversation

@amanmahajan7
Copy link
Collaborator

@amanmahajan7 amanmahajan7 commented Sep 18, 2025

https://voidzero.dev/posts/announcing-vitest-4
https://vitest.dev/guide/migration.html

Had to add special cases for FF due to scale being set to 0.6666666
vitest-dev/vitest#8783

@amanmahajan7 amanmahajan7 self-assigned this Sep 18, 2025
@amanmahajan7 amanmahajan7 changed the title Setup VRT Update Vitest Oct 23, 2025
await resizeHandle.hover({
position: { x: 5, y: 5 }
});
await page.mouse.move(x + 5, y + 5);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives more accurate dimensions

name: 'browser',
include: ['test/browser/**/*.test.*'],
browser: {
ui: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headed tests fail without it. Thanks to @nstepien

@amanmahajan7 amanmahajan7 marked this pull request as ready for review October 23, 2025 18:18
Comment on lines +12 to +14
.vitest-attachments

__traces__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do each one contain?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanmahajan7 amanmahajan7 merged commit 8f5ccef into main Oct 24, 2025
2 checks passed
@amanmahajan7 amanmahajan7 deleted the vrt branch October 24, 2025 13:35
royue pushed a commit to royue/react-data-grid that referenced this pull request Dec 17, 2025
* Vitest 4 beta

* Use SHA

* Set up workflow

* first test

* run workflow on lael

* format

* Tweak

* manually run workflow

* typo

* main

* Tweak

* fix syntax

* revert

* Fix step

* Update command

* Do we need this command?

* Revert "Do we need this command?"

This reverts commit 7a66594.

* Does this remove label?

* set env

* try `actions-ecosystem/action-remove-labels`

* New approach

* Does this work

* Update visual regression screenshots

Co-authored-by: amanmahajan7

* Does this work?

* Try this

* Update visual regression screenshots

Co-authored-by: amanmahajan7

* Simplify

* remove name

* Update visual regression screenshots

Co-authored-by: amanmahajan7

* Tweaks

* Fix permissions

* Tweak

* test

* Does this work?

* Update screenshots

Co-authored-by: amanmahajan7

* Tweaks

* Tweak coverage

* Tweak coverage

* Does this work?

* Does this work?

* Does this work?

* Does this work?

* Fix watch

* different coverage directories?

* Fix typo

* Another

* `beta.12`

* Run VRT in FF also

* install ff

* Update screenshots

Co-authored-by: amanmahajan7

* Fix tests

* update package

* update test

* Update screenshots

Co-authored-by: amanmahajan7

* add formatter

* Update screenshots

Co-authored-by: amanmahajan7

* pin

* Still need this :(

* unpin

* Update deps

* Import from `vitest/browser`

* update deps

* Add back clsx

* Fix biome/eslint

* update deps

* Use async render

* Move async

* Fix eslint

* Enable tracing

* Remove VRT changes

* Revert .gitignore changes

* Fix types

* fix 2 tests

* set scale

* Fix tests for now

* Revert commands

* typo

* Update tsconfig.test.json

Co-authored-by: Nicolas Stepien <[email protected]>

* Update package.json

Co-authored-by: Nicolas Stepien <[email protected]>

* Revert "Update package.json"

This reverts commit 41445b1.

* remove @vitest/browser

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants