Rewrite some tests to reduce flakiness: part 3 #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Oct 3, 2025
| firefox, | ||
| firefoxCI | ||
| ]); | ||
| await vi.waitFor(() => { |
Collaborator
Author
There was a problem hiding this comment.
test/browser/renderers.test.tsx
Outdated
| setup({ columns, rows: noRows, renderers: { noRowsFallback: <NoRowsFallback /> } }); | ||
|
|
||
| expect(getRows()).toHaveLength(0); | ||
| await testLength(getRowsNew(), 1); |
Collaborator
Author
There was a problem hiding this comment.
I think using page.getByRole('row').elements().slice(1) causes confusion IMO. We can just check the total row count. Also, we can await now
| reactStrictMode: true | ||
| }); | ||
|
|
||
| locators.extend({ |
Collaborator
Author
There was a problem hiding this comment.
nstepien
previously approved these changes
Oct 22, 2025
Co-authored-by: Nicolas Stepien <[email protected]>
nstepien
approved these changes
Oct 22, 2025
royue
pushed a commit
to royue/react-data-grid
that referenced
this pull request
Dec 17, 2025
* -1 * -1 * eslint * Add `testLength` util * Add `getRowByCellName` util * Revert accidental change * -1 * Remove unused * Export * Rename * Add missing import * -1 * -1 * Rename * Rename helper * Pin eslint? * Update test/browser/utils.tsx Co-authored-by: Nicolas Stepien <[email protected]> * Fix types --------- Co-authored-by: Nicolas Stepien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.