-
Notifications
You must be signed in to change notification settings - Fork 3
[test] Add pyproject.toml generation validation #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove CI workflow that was causing failures - Remove test file with MongoDB dependencies - Keep preview scripts for developers to test pyproject.toml generation - Update package.json scripts for easier usage
|
*clicked update branch should solve CICD errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test validation tools for pyproject.toml generation functionality, introducing preview scripts that help validate the output of the core ComfyUI node initialization process. The changes focus on testing infrastructure rather than production code.
- Adds two preview scripts for validating pyproject.toml generation in different scenarios
- Introduces npm scripts for easy access to the preview functionality
- Provides debugging tools to ensure the main PR creation workflow produces valid output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/preview-pyproject-toml.ts | Full-featured preview script that clones repositories and generates pyproject.toml files with cleanup |
| scripts/preview-pyproject-minimal.ts | Minimal preview script for testing pyproject.toml generation in empty directories |
| package.json | Adds npm scripts for running the preview tools and test watching |
|
LGTM and tested in my end, @christian-byrne do you want merge this or make further changes? |
|
Originally I just made this PR to show you my script. Do you want to merge it still? You don't have to! |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Want! |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
- Created independent tsconfig.json for scripts to avoid build conflicts - Removed extends from parent tsconfig to make scripts truly standalone - Added scripts directory to main tsconfig exclude list - Fixed module resolution for scripts importing from src - Scripts now compile independently without affecting main build
Adds test coverage and preview tools for pyproject.toml generation, ensuring the core PR creation functionality produces valid output. Also introduces CI workflow for automated testing.