Skip to content

Conversation

@christian-byrne
Copy link
Contributor

Adds test coverage and preview tools for pyproject.toml generation, ensuring the core PR creation functionality produces valid output. Also introduces CI workflow for automated testing.

@vercel
Copy link
Contributor

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
comfy-pr Ready Ready Preview Comment Sep 17, 2025 6:30am

- Remove CI workflow that was causing failures
- Remove test file with MongoDB dependencies
- Keep preview scripts for developers to test pyproject.toml generation
- Update package.json scripts for easier usage
@snomiao
Copy link
Member

snomiao commented Jul 17, 2025

*clicked update branch

should solve CICD errors

@snomiao snomiao requested review from Copilot and snomiao July 17, 2025 04:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test validation tools for pyproject.toml generation functionality, introducing preview scripts that help validate the output of the core ComfyUI node initialization process. The changes focus on testing infrastructure rather than production code.

  • Adds two preview scripts for validating pyproject.toml generation in different scenarios
  • Introduces npm scripts for easy access to the preview functionality
  • Provides debugging tools to ensure the main PR creation workflow produces valid output

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
scripts/preview-pyproject-toml.ts Full-featured preview script that clones repositories and generates pyproject.toml files with cleanup
scripts/preview-pyproject-minimal.ts Minimal preview script for testing pyproject.toml generation in empty directories
package.json Adds npm scripts for running the preview tools and test watching

@snomiao
Copy link
Member

snomiao commented Jul 17, 2025

LGTM and tested in my end, @christian-byrne do you want merge this or make further changes?

@christian-byrne
Copy link
Contributor Author

Originally I just made this PR to show you my script. Do you want to merge it still? You don't have to!

@snomiao
Copy link
Member

snomiao commented Jul 19, 2025

Originally I just made this PR to show you my script. Do you want to merge it still? You don't have to!

Want!

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
[email protected] has Obfuscated code.

Confidence: 0.94

Location: Package overview

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

- Created independent tsconfig.json for scripts to avoid build conflicts
- Removed extends from parent tsconfig to make scripts truly standalone
- Added scripts directory to main tsconfig exclude list
- Fixed module resolution for scripts importing from src
- Scripts now compile independently without affecting main build
@snomiao snomiao merged commit 29cf49e into main Sep 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants