Skip to content

Only load legacy FE extension if --enable-manager-legacy-ui is set #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltdrdata merged 2 commits into from
Apr 14, 2025
Merged

Only load legacy FE extension if --enable-manager-legacy-ui is set #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4edfbc
only load JS extensions when legacy arg is set
christian-byrne Apr 14, 2025
d0a6bda
add `is_legacy_manager_ui` endpoint
christian-byrne Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions comfyui_manager/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
import logging
from comfy.cli_args import args

ENABLE_LEGACY_COMFYUI_MANAGER_FRONT_DEFAULT = True # Enable legacy ComfyUI Manager frontend while new UI is in beta phase

def prestartup():
from . import prestartup_script # noqa: F401
logging.info('[PRE] ComfyUI-Manager')
Expand All @@ -14,8 +12,7 @@ def start():
from .common import cm_global # noqa: F401

if not args.disable_manager:
should_show_legacy_manager_front = args.enable_manager_legacy_ui or ENABLE_LEGACY_COMFYUI_MANAGER_FRONT_DEFAULT
if should_show_legacy_manager_front:
if args.enable_manager_legacy_ui:
try:
from .legacy import manager_server # noqa: F401
from .legacy import share_3rdparty # noqa: F401
Expand Down
7 changes: 7 additions & 0 deletions comfyui_manager/glob/manager_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,13 @@ def populate_markdown(x):
if 'title' in x:
x['title'] = manager_util.sanitize_tag(x['title'])

@routes.get("/v2/manager/is_legacy_manager_ui")
async def is_legacy_manager_ui(request):
return web.json_response(
{"is_legacy_manager_ui": args.enable_manager_legacy_ui},
content_type="application/json",
status=200,
)

# freeze imported version
startup_time_installed_node_packs = core.get_installed_node_packs()
Expand Down