[feat] Implement comprehensive batch tracking and OpenAPI-driven data models #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add-ModelQuantizer to custom node list * Update custom-node-list.json --------- Co-authored-by: yogotatara3 <[email protected]> Co-authored-by: Dr.Lt.Data <[email protected]>
added entry for Sample Scheduler Metrics Tester custom node
* add AQnodes * add AQnodes - fix repo url --------- Co-authored-by: pk <[email protected]>
* [docs] Add README for js directory * [docs] Update js/README.md based on PR review feedback * [docs] Update js/README.md with corrected descriptions
* [docs] Add README for docs directory * [docs] Remove redundant sections from docs README
Fixed node references to github
Splitting the Level Pixel node package into two separate packages: https://github.com/LevelPixel/ComfyUI-LevelPixel https://github.com/LevelPixel/ComfyUI-LevelPixel-Advanced Adding information about the new ComfyUI-LevelPixel-Advanced node package to custom-node-list.json. The new ComfyUI-LevelPixel-Advanced node package is needed to separate the complex to install and use LLM and VLM node package from the rest of the main nodes of Level Pixel. Conflicting nodes will be removed from ComfyUI-LevelPixel later.
* set channel=default, mode=cache for git clone * fix(manager_util): use normalized_name of package in fix_broken Signed-off-by: bigcat88 <[email protected]> --------- Signed-off-by: bigcat88 <[email protected]>
…d via `git clone` if its URL has changed or if the node is not registered in `custom-nodes-list.json`. #1834 (comment)
New input sockets have no pos, and require a render frame to occur before links can be set to the correct location.
the existing cache-based implementation will be retained as a fallback under legacy/..., while glob/... will be updated to a cacheless implementation.
…1746) * only load JS extensions when legacy arg is set * add `is_legacy_manager_ui` endpoint
…1748) * add `is_legacy_manager_ui` route to `legacy` package as well * add static
fixed: prestartup_script - remove useless exception handling when fallback resolving comfy_path
modified: /ltdrdata -> /Comfy-Org modified: set default network as public instead of offline
Network mode does not simply determine whether the CNR cache is used. Even after switching to cacheless in the future, it will continue to be used as a policy for user environments.
modified: convert cm-cli.sh to cm-cli command
- Add client_id field to QueueTaskItem and TaskHistoryItem models - Implement client-specific WebSocket message routing - Add client filtering to queue status and history endpoints - Follow ComfyUI patterns for session management - Create data_models package for better code organization
… models Enhances ComfyUI Manager with robust batch execution tracking and unified data model architecture: - Implemented automatic batch history serialization with before/after system state snapshots - Added comprehensive state management capturing installed nodes, models, and ComfyUI version info - Enhanced task queue with proper client ID handling and WebSocket notifications - Migrated all data models to OpenAPI-generated Pydantic models for consistency - Added documentation for new TaskQueue methods (done_count, total_count, finalize) - Fixed 64 linting errors with proper imports and code cleanup Technical improvements: - All models now auto-generated from openapi.yaml ensuring API/implementation consistency - Batch tracking captures complete system state at operation start and completion - Enhanced REST endpoints with comprehensive documentation - Removed manual model files in favor of single source of truth - Added helper methods for system state capture and batch lifecycle management
Contributor
Author
|
Inadvertant rebase included in this PR. |
Contributor
Author
|
Replaced by #1915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances ComfyUI Manager with robust batch execution tracking and unified data model architecture. Implements automatic batch history serialization with complete system state snapshots, migrates all data models to OpenAPI-generated Pydantic models for consistency, and adds comprehensive client ID handling with WebSocket notifications.
Key improvements include capturing system state at operation start/completion, enhanced task queue documentation, and removal of manual model files in favor of a single source of truth from the OpenAPI specification.