[API Nodes]: fixes and refactor #11104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied
ruff check comfy_api_nodes --fixwhile temporarily setting the minimum Python version to3.10and adding theUPrule.Added
validate_video_frame_countfunction from this PRRemoved imports of
V1files, and replaced them by correct import fromV3schema.Additionally, finally, fixed the
poll_opreturn typing:Updated
poll_opextractor type hints fromCallable[[M], ...]toCallable[[M | Any], ...]response_modeland the lambda arguments, causing the final return type ofpoll_opto be lost.Anycreates a permissive union that allows the IDE/type-checkers to resolveMsolely fromresponse_model, restoring strict typing for the function result.Callable[..., ...](Ellipsis) was rejected because, while it fixes the inference issue, it loses argument count validation and hides the API intent that the callback receives typeM.API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms