Skip to content

[BlockInfo] Lumina #11227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kosinkadink merged 4 commits into from
Dec 16, 2025
Merged

[BlockInfo] Lumina #11227

Kosinkadink merged 4 commits into from
Dec 16, 2025

Conversation

@Haoming02
Copy link
Contributor

@Haoming02 Haoming02 commented Dec 10, 2025

  1. Added 3 block informations to the transformer_options for Lumina & Z-Image:
    • block_index - the index of the current block
    • total_blocks - the total amount of blocks of that type
    • block_type - single / double

@Kosinkadink
Copy link
Member

Kosinkadink commented Dec 11, 2025

Can you also make the tensors be created on the CPU on this one as well?

@Kosinkadink
Copy link
Member

Kosinkadink commented Dec 16, 2025

Comfy was able to get the int stuff not to cause a massive amount of graph breaks via #11317, so if you can get this PR back to using ints instead of tensors, I can merge it! Sorry for the drawn out back and forth.

@Kosinkadink Kosinkadink mentioned this pull request Dec 16, 2025
Closed
@Kosinkadink Kosinkadink added the Core Core team dependency label Dec 16, 2025
Kosinkadink
Kosinkadink approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@Kosinkadink Kosinkadink merged commit fc4af86 into Comfy-Org:master Dec 16, 2025
10 checks passed
@Haoming02 Haoming02 deleted the bInfo-Lumina branch December 16, 2025 02:00
lrivera pushed a commit to Research-Warrant/ComfyUI that referenced this pull request Jan 8, 2026
@Haoming02 @Kosinkadink @lrivera
[BlockInfo] Lumina (Comfy-Org#11227)
6fbac51 
* block info

* device

* Make tensor int again

---------

Co-authored-by: Jedrzej Kosinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guill guill guill approved these changes

@Kosinkadink Kosinkadink Kosinkadink approved these changes

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

+1 more reviewer

@PlagueBread666 PlagueBread666 PlagueBread666 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Core Core team dependency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Haoming02 @Kosinkadink @guill @PlagueBread666