fix: use float32 for Qwen image rotary embeddings #11683
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using torch.compile with bfloat16 inference, Qwen image models fail with:
Root Cause
Commit
4cd88186('Use single apply_rope function across models') refactored all models to use a sharedapply_rope1function and correctly set Qwen'simage_rotary_embto.to(torch.float32)Commit
c4a6b389('Lower ltxv mem usage') inadvertently reverted Qwen back to.to(x.dtype)(bfloat16), breaking compatibility with the sharedapply_rope1functionThe
apply_rope1function usesaddcmul_in-place operations that fail undertorch.compilewhenfreqs_cisis bfloat16Fix
This restores the correct behavior by ensuring
image_rotary_embis alwaysfloat32for the Qwen model, matching the expected dtype forapply_rope1.Testing
Tested with Qwen Image Edit workflows on cloud deployment.