add preview 3d node #6070
Merged
add preview 3d node #6070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
requested review from
Kosinkadink,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
huchenlei
previously approved these changes
Dec 16, 2024
Contributor
|
Note: currently |
huchenlei
reviewed
Dec 16, 2024
Contributor
Author
Sure, I will think abou it |
Contributor
Author
|
@huchenlei one test (regarding hunyuan node?) failed but I don't see any relevent to my changes. |
Contributor
Can you rebase to the head of master? Missing imports are fixed in 0b25f47 |
robinjhuang
approved these changes
Dec 17, 2024
huchenlei
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even we discussed in #5564 that should move this preview 3d into FE, however after investigated, I could not figure out how to do that, the main reason is when execute workflow, comfyUI will validate note mapping here https://github.com/comfyanonymous/ComfyUI/blob/6d1a3f7d00d92b652b986ef69b4337ea0f208a1a/execution.py#L775 but the pure FE node doesn't have such Python Class, I believe we still need one BE node here.
Here is a demo video
2024-12-15.22-54-45.mp4
FE PR is Comfy-Org/ComfyUI_frontend#1918