Skip to content

Better argument handling of front-end-root #7043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comfyanonymous merged 2 commits into from
Mar 5, 2025
Merged

Better argument handling of front-end-root #7043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a92dd1
Better argument handling of front-end-root
silveroxides Mar 2, 2025
ed2665b
Removed unused import
silveroxides Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions comfy/cli_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import argparse
import enum
import os
from typing import Optional
import comfy.options


Expand Down Expand Up @@ -166,13 +165,14 @@ class PerformanceFeature(enum.Enum):
""",
)

def is_valid_directory(path: Optional[str]) -> Optional[str]:
"""Validate if the given path is a directory."""
if path is None:
return None

def is_valid_directory(path: str) -> str:
"""Validate if the given path is a directory, and check permissions."""
if not os.path.exists(path):
raise argparse.ArgumentTypeError(f"The path '{path}' does not exist.")
if not os.path.isdir(path):
raise argparse.ArgumentTypeError(f"{path} is not a valid directory.")
raise argparse.ArgumentTypeError(f"'{path}' is not a directory.")
if not os.access(path, os.R_OK):
raise argparse.ArgumentTypeError(f"You do not have read permissions for '{path}'.")
return path

parser.add_argument(
Expand Down