[NodeDef] Explicitly add control_after_generate to seed/noise_seed #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested review from
Kosinkadink,
comfyanonymous,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
webfiltered
previously approved these changes
Mar 4, 2025
Member
|
We should consider that |
Contributor
I believe this is purely cosmetic in the frontend code. The setting is global iirc, so there's really just one widget that can show two different names. |
Co-authored-by: filtered <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the frontend is assigning
control_after_generateoption for matching exactlyINTinput type andseed&noise_seedinput name.There is currently no way to disable the linked control widget when the condition is met.
This PR explicitly add
control_after_generateto node definitions to prepare us deprecate the logic in the frontend.