auto register web folder from pyproject #8478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2025
Member
|
Can you fix it? |
jtydhr88
requested review from
Kosinkadink,
christian-byrne,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
comfyanonymous
added a commit
that referenced
this pull request
Jun 11, 2025
This reverts commit 9685d4f.
comfyanonymous
added a commit
that referenced
this pull request
Jun 11, 2025
Member
|
I reverted it, can you make it not completely fail if the dependency is missing and warn the user to update the requirements.txt ? |
Contributor
Author
|
Sure, will do soon |
This was referenced Jun 12, 2025
adlerfaulkner
pushed a commit
to LucaLabsInc/ComfyUI
that referenced
this pull request
Oct 16, 2025
* auto register web folder from pyproject * need pydantic-settings as dependency
adlerfaulkner
pushed a commit
to LucaLabsInc/ComfyUI
that referenced
this pull request
Oct 16, 2025
…mfy-Org#8497) This reverts commit 9685d4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
license = "GPL-3.0 license"format which is not allowed previously (has validation error).It should have cli PR here Comfy-Org/comfy-cli#284 merged at the same time
Tested with Comfy-Org/ComfyUI-React-Extension-Template#12
Additonally, why do we still need this web folder read from pyproject after we have the logic of
hasattr(module, "WEB_DIRECTORY")below?From my understanding, the biggest benefit is that pyproject files can be used for ComfyRegister, and we can do additional security checks on these frontend files on the server side in the future.