Skip to content

Conversation

@Balladie
Copy link
Contributor

@Balladie Balladie commented Aug 25, 2025

Following up of #9444.

DPM++ 2M SDE with Heun solver type leads to the same formulation with RES, and this work adds dpmpp_2m_sde_heun sampler and removes res_multistep_ancestral that is not working on RF currently.

Checked that it produces the same results with fixed res_multistep_ancestral in #9444, with the last Euler step disabled and the noise sampler replaced to BrownianTreeNoiseSampler.

Example results from FLUX Krea:

before, res_multistep_ancestral #9444, res_multistep_ancestral matched, res_multistep_ancestral dpmpp_2m_sde_heun
flux_krea_res_multistep_ancestral_s20_before flux_krea_res_multistep_ancestral flux_krea_res_multistep_ancestral_match flux_krea_dpmpp_2m_sde_heun

@comfyanonymous
Copy link
Member

can you leave the res_multistep_ancestral_* samplers in? To ensure a clean migration I need to coordinate with the frontend people.

@Balladie
Copy link
Contributor Author

can you leave the res_multistep_ancestral_* samplers in? To ensure a clean migration I need to coordinate with the frontend people.

restored them

@comfyanonymous comfyanonymous merged commit 3aad339 into Comfy-Org:master Aug 27, 2025
6 checks passed
@nestflow
Copy link

nestflow commented Sep 9, 2025

Thanks for the great work! Since you mentioned dpmpp_2m_sde_heun is basically the same as res_multistep_ancestral (maybe a little improved?), I wonder if we could migrate CFG++ implementation to it?

At least in my test dpmpp_2m_sde_heun does feel a bit better than res_multistep_ancestral for SDXL models, so it would be nice to have the CFG++ variation to compare with res_multistep_ancestral_cfp_pp.

@Balladie
Copy link
Contributor Author

Thanks for the great work! Since you mentioned dpmpp_2m_sde_heun is basically the same as res_multistep_ancestral (maybe a little improved?), I wonder if we could migrate CFG++ implementation to it?

At least in my test dpmpp_2m_sde_heun does feel a bit better than res_multistep_ancestral for SDXL models, so it would be nice to have the CFG++ variation to compare with res_multistep_ancestral_cfp_pp.

please refer to #9820 @nestflow

toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants