Skip to content

Commit 61e765c

Browse files
christian-byrneclaudegithub-actions
authored andcommitted
[test] fix flaky Vue upload widget browser tests using randomize url param (#5845)
Fix browser tests that use filenames in loader nodes. When the files don't exist, the fallback/error component shows the request URL which contains random cache-busting param which makes tests fail due to non-deterministic nature. [Context](#5831 (comment)) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5845-test-fix-flaky-Vue-upload-widget-browser-tests-using-randomize-url-param-27d6d73d36508107a0d0d52d2764a028) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent 8e73160 commit 61e765c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

browser_tests/assets/widgets/all_load_widgets.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"Node name for S&R": "LoadVideo"
6262
},
6363
"widgets_values": [
64-
"Dying for the right cause, is the most human thing we can do [sOBtQofXPDA].mp4",
64+
null,
6565
"image"
6666
]
6767
},
@@ -96,7 +96,7 @@
9696
"Node name for S&R": "DevToolsLoadAnimatedImageTest"
9797
},
9898
"widgets_values": [
99-
"l0isitzgugt41.webp",
99+
null,
100100
"image"
101101
]
102102
},
@@ -131,7 +131,7 @@
131131
"Node name for S&R": "LoadImage"
132132
},
133133
"widgets_values": [
134-
"ComfyUI_00084_.png",
134+
null,
135135
"image"
136136
]
137137
},
@@ -161,7 +161,7 @@
161161
"Node name for S&R": "LoadImageMask"
162162
},
163163
"widgets_values": [
164-
"01. a lot.mp3",
164+
null,
165165
"alpha",
166166
"image"
167167
]
@@ -197,7 +197,7 @@
197197
"Node name for S&R": "LoadImageOutput"
198198
},
199199
"widgets_values": [
200-
"ComfyUI_00509_.png [output]",
200+
null,
201201
false,
202202
"refresh",
203203
"image"

0 commit comments

Comments
 (0)