Skip to content

Commit 8e73160

Browse files
christian-byrnegithub-actions
authored andcommitted
designate canvasOnly on runtime-generated virtual widgets so they are hidden in Vue renderer (#5831)
Added `canvasOnly` flag to runtime-generated widgets to prevent Vue renderer from displaying them while keeping canvas functionality intact. - **What**: Added `canvasOnly` widget option to hide upload, webcam, and refresh widgets from Vue renderer In the Canvas (LiteGraph) system, there was a small set of widgets with strictly defined components. There, if we wanted some unique or relatively complex behavior (like an upload butotn), we needed to create a separate widget that would be coupled to the original widget at runtime (and would not be serialized). In the Vue renderer system, we can simply add flags to the inputSpec or widget options and conditionally render complex UI additions -- i.e., there is no need for the hard-to-maintain runtime widget associations. Expressing such things entirely in the view layer simplifies business logic related to graph state, as we no longer need to account for preserving the connections between runtime widgets and their special siblings -- we also do not need to worry about the implications for state serialization. - #5798 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5831-designate-canvasOnly-on-runtime-generated-virtual-widgets-so-they-are-hidden-in-Vue-ren-27c6d73d365081fb8641feec010190df) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
1 parent 8faf3b6 commit 8e73160

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

browser_tests/assets/widgets/all_load_widgets.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"Node name for S&R": "LoadVideo"
6262
},
6363
"widgets_values": [
64-
null,
64+
"Dying for the right cause, is the most human thing we can do [sOBtQofXPDA].mp4",
6565
"image"
6666
]
6767
},
@@ -96,7 +96,7 @@
9696
"Node name for S&R": "DevToolsLoadAnimatedImageTest"
9797
},
9898
"widgets_values": [
99-
null,
99+
"l0isitzgugt41.webp",
100100
"image"
101101
]
102102
},
@@ -131,7 +131,7 @@
131131
"Node name for S&R": "LoadImage"
132132
},
133133
"widgets_values": [
134-
null,
134+
"ComfyUI_00084_.png",
135135
"image"
136136
]
137137
},
@@ -161,7 +161,7 @@
161161
"Node name for S&R": "LoadImageMask"
162162
},
163163
"widgets_values": [
164-
null,
164+
"01. a lot.mp3",
165165
"alpha",
166166
"image"
167167
]
@@ -197,7 +197,7 @@
197197
"Node name for S&R": "LoadImageOutput"
198198
},
199199
"widgets_values": [
200-
null,
200+
"ComfyUI_00509_.png [output]",
201201
false,
202202
"refresh",
203203
"image"
@@ -218,4 +218,4 @@
218218
"frontendVersion": "1.28.3"
219219
},
220220
"version": 0.4
221-
}
221+
}

0 commit comments

Comments
 (0)