Skip to content

Commit d9e6298

Browse files
remove all auth service work related code (#6294)
## Summary Removes all service worker auth code, as it is being replaced by a more robust standard solution for authenticating view and viewvideo requests in #6295. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6294-remove-all-auth-service-work-related-code-2986d73d36508170a24bf1c42cad401e) by [Unito](https://www.unito.io)
1 parent e5d5c04 commit d9e6298

File tree

9 files changed

+2
-456
lines changed

9 files changed

+2
-456
lines changed

eslint.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ export default defineConfig([
6060
'**/vite.config.*.timestamp*',
6161
'**/vitest.config.*.timestamp*',
6262
'packages/registry-types/src/comfyRegistryTypes.ts',
63-
'public/auth-dev-sw.js',
64-
'public/auth-sw.js',
6563
'src/extensions/core/*',
6664
'src/scripts/*',
6765
'src/types/generatedManagerTypes.ts',

knip.config.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,7 @@ const config: KnipConfig = {
4141
'src/workbench/extensions/manager/types/generatedManagerTypes.ts',
4242
'packages/registry-types/src/comfyRegistryTypes.ts',
4343
// Used by a custom node (that should move off of this)
44-
'src/scripts/ui/components/splitButton.ts',
45-
// Service workers - registered at runtime via navigator.serviceWorker.register()
46-
'public/auth-sw.js',
47-
'public/auth-dev-sw.js'
44+
'src/scripts/ui/components/splitButton.ts'
4845
],
4946
compilers: {
5047
// https://github.com/webpro-nl/knip/issues/1008#issuecomment-3207756199

public/auth-dev-sw.js

Lines changed: 0 additions & 168 deletions
This file was deleted.

public/auth-sw.js

Lines changed: 0 additions & 179 deletions
This file was deleted.

src/main.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,4 @@ app
8282
modules: [VueFireAuth()]
8383
})
8484

85-
// Register auth service worker after Pinia is initialized (cloud-only)
86-
// Wait for registration to complete before mounting to ensure SW controls the page
87-
if (isCloud) {
88-
await import('@/platform/auth/serviceWorker')
89-
}
90-
9185
app.mount('#vue-app')

src/platform/auth/serviceWorker/index.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)