[3d] add output preview screen for load3d node #2464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
suggested changes
Feb 8, 2025
Contributor
huchenlei
left a comment
huchenlei
left a comment
There was a problem hiding this comment.
Is it possible we build the UI with Vue/PrimeVue here? We don't need to reinvent some basic components like slider and svg icons.
You can reference
ComfyUI_frontend/src/components/sidebar/tabs/NodeLibrarySidebarTab.vue
Lines 126 to 132 in a914456
| container.classList.add('comfy-load-3d') | ||
|
|
||
| const load3d = new Load3d(container) | ||
| const load3d = new Load3d(container, true) |
Contributor
There was a problem hiding this comment.
Prefer using kwargs here. A boolean true second param will make reader confused.
| container.classList.add('comfy-load-3d-animation') | ||
|
|
||
| const load3d = new Load3dAnimation(container) | ||
| const load3d = new Load3dAnimation(container, true) |
Contributor
There was a problem hiding this comment.
Prefer using kwargs here. A boolean true second param will make reader confused.
|
|
||
| constructor( | ||
| container: Element | HTMLElement, | ||
| createPreview: boolean = false |
Contributor
There was a problem hiding this comment.
Prefer using kwargs here. A boolean true second param will make reader confused.
Collaborator
Author
|
close it for now, I will use vue to re-write first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a output preview screen for load3d, because at before, it is hard to know the output exactly.
also moved two params (fov and light intensity) from node panel to the scene.
here is the demo:
https://github.com/user-attachments/assets/401f7773-a219-47de-b529-864c83ba7370
need Comfy-Org/ComfyUI#6742 as BE change
┆Issue is synchronized with this Notion page by Unito