Skip to content

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Mar 11, 2025

Ref: Comfy-Org/ComfyUI#7197

Wrap widget value in object to clearly distinguish between node connection. Note: the API format previously used will still be compatible after the change, but the API workflow format produced after the change won't be able to be used on previous ComfyUI versions.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner March 11, 2025 23:55
@AustinMroz
Copy link
Collaborator

This is disappointing to see. I have a (currently unreleased) project I've been working on that makes use of the ability for a widget to serialize to a link, but I consider that project rather frivolous and would not want it alone to impede development.

All the same, it seems awfully heavy handed to wrap all widget values to handle a rare edge case instead of allowing a widget that wants to serialize as a list to itself wrap using this introduced format.

@huchenlei
Copy link
Contributor Author

This is disappointing to see. I have a (currently unreleased) project I've been working on that makes use of the ability for a widget to serialize to a link, but I consider that project rather frivolous and would not want it alone to impede development.

All the same, it seems awfully heavy handed to wrap all widget values to handle a rare edge case instead of allowing a widget that wants to serialize as a list to itself wrap using this introduced format.

Thinking again, probably the best approach here is to restrict the wrapping to array values for max compatibility. Thanks for pointing this out!

@huchenlei huchenlei merged commit 313f32b into main Mar 12, 2025
10 checks passed
@huchenlei huchenlei deleted the widget_list_value branch March 12, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants