Skip to content

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Mar 31, 2025

Resolves #3192
Resolves #1998

It has been annoying to load a workflow with missing nodes when you simply want to copy the prompt string from the workflow. This PR adds widgets to nodes with missing definition, so that the widgets values are visible to the user even the node definition is missing.

image

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Mar 31, 2025
@huchenlei huchenlei requested a review from a team as a code owner March 31, 2025 17:45
@huchenlei
Copy link
Contributor Author

Ref: Comfy-Org/rfcs#2

We should have the widget name available once the new workflow format is ready.

@github-actions github-actions bot requested a review from a team as a code owner March 31, 2025 17:55
@huchenlei huchenlei merged commit f26f5f2 into main Mar 31, 2025
2 checks passed
@huchenlei huchenlei deleted the error_widgets branch March 31, 2025 18:23
@Amorano
Copy link
Contributor

Amorano commented Mar 31, 2025

thank you.

christian-byrne pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Browser Test Expectations New browser test screenshot should be set by github action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Show serialized "values" of missing nodes [Feature Request]: Quick access to missing node json or list of widget values.

3 participants