Skip to content

[fix] Detect missing nodes in subgraphs #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 9 commits into from
Jul 29, 2025
Merged

[fix] Detect missing nodes in subgraphs #4547

christian-byrne merged 9 commits into from
Jul 29, 2025

Conversation

@viva-jinyi
Copy link
Member

@viva-jinyi viva-jinyi commented Jul 27, 2025 •
edited
Loading

Summary

  • Use collectAllNodes utility to recursively scan subgraphs for missing custom nodes
  • Update both useMissingNodes and useWorkflowPacks to include nodes from all graph levels
  • This ensures Manager can detect and list custom nodes that are inside subgraphs

Test plan

  • Create a workflow with custom nodes inside a subgraph
  • Load the workflow in a ComfyUI instance without those custom nodes installed
  • Open Manager → "Install Missing Custom Nodes"
  • Verify that custom nodes from inside subgraphs are now listed

Fixes #2032

┆Issue is synchronized with this Notion page by Unito

@viva-jinyi viva-jinyi requested a review from a team as a code owner July 27, 2025 07:56
@github-actions
Copy link

github-actions bot commented Jul 27, 2025 •
edited
Loading

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@viva-jinyi viva-jinyi force-pushed the fix/subgraph-missing-nodes branch from c144551 to 34b8f42 Compare July 27, 2025 07:57
@viva-jinyi viva-jinyi requested a review from a team as a code owner July 27, 2025 08:06
@viva-jinyi viva-jinyi self-assigned this Jul 27, 2025
christian-byrne
christian-byrne reviewed Jul 27, 2025
View reviewed changes
@viva-jinyi viva-jinyi force-pushed the fix/subgraph-missing-nodes branch from a6f3d2d to 4cce37e Compare July 28, 2025 23:26
@viva-jinyi
[fix] Detect missing nodes in subgraphs
5c31eb1 
Use collectAllNodes to recursively scan subgraphs for missing custom nodes.

Fixes #2032
@viva-jinyi
[test] Add subgraph support tests for useMissingNodes
db1f4e2 
- Mock collectAllNodes to test subgraph node detection
- Update existing tests to use collectAllNodes mock
- Add new test cases for subgraph scenarios
@viva-jinyi
[fix] Add missing @ts-expect-error for test store mocks
6cb18c0
@viva-jinyi
[refactor] use filter option in collectAllNodes
6188f71
@viva-jinyi
[test] missing subgraph test case added
5fa2743
@viva-jinyi
[test] unused variables deleted
0f692f9
@viva-jinyi
[test] unused variables deleted
75a7cc9
@viva-jinyi viva-jinyi force-pushed the fix/subgraph-missing-nodes branch from c121a53 to 75a7cc9 Compare July 29, 2025 01:33
christian-byrne
christian-byrne approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

src/composables/nodePack/useWorkflowPacks.ts
Comment on lines +116 to +119
if (!app.graph) return []
const allNodes = collectAllNodes(app.graph)
if (!allNodes.length) return []
const packs = await Promise.all(allNodes.map(workflowNodeToPack))
Copy link
Contributor

@christian-byrne christian-byrne Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this one

@christian-byrne christian-byrne merged commit 680c09a into main Jul 29, 2025
12 checks passed
@christian-byrne christian-byrne deleted the fix/subgraph-missing-nodes branch July 29, 2025 04:55
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch area:subgraph labels Jul 29, 2025
@christian-byrne christian-byrne mentioned this pull request Jul 29, 2025
Merged
3 tasks
christian-byrne pushed a commit that referenced this pull request Aug 4, 2025
@viva-jinyi @christian-byrne
[fix] Detect missing nodes in subgraphs (#4547)
c516155 
Co-authored-by: github-actions <[email protected]>
christian-byrne pushed a commit that referenced this pull request Aug 4, 2025
@viva-jinyi @christian-byrne
[fix] Detect missing nodes in subgraphs (#4547)
00c36c7 
Co-authored-by: github-actions <[email protected]>
@christian-byrne christian-byrne mentioned this pull request Aug 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

@Yorha4D Yorha4D Awaiting requested review from Yorha4D

@KarryCharon KarryCharon Awaiting requested review from KarryCharon

@shinshin86 shinshin86 Awaiting requested review from shinshin86

Assignees

@viva-jinyi viva-jinyi

Labels

area:subgraph needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug/Oversight] Custom node suites are not picked up from subgraphs

3 participants

@viva-jinyi @christian-byrne