fix: Add checkout step before using local action in update-locales workflow #5938
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow Use actions/checkout@v5 to checkout the repository before referencing the local custom action ./.github/actions/setup-frontend
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/07/2025, 05:35:31 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 10/07/2025, 05:59:53 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
dosubot
bot
added
the
size:XS
|
@christian-byrne @DrJKL ready for review, workflow already tested in this PR and then reverted the testing code. |
DrJKL
approved these changes
Oct 7, 2025
christian-byrne
approved these changes
Oct 7, 2025
christian-byrne
pushed a commit
that referenced
this pull request
Oct 8, 2025
…rkflow (#5938) ## Problem The `update-locales` workflow was failing with the error: ``` Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/ComfyUI_frontend/ComfyUI_frontend/.github/actions/setup-frontend'. Did you forget to run actions/checkout before running your local action? ``` Ref: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18270266173/job/52011427608 ## Solution Added a checkout step using `actions/checkout@v5` before the "Setup Frontend" step. This ensures the repository code (including the local action definition) is available before GitHub Actions tries to use it. ## Changes - Added checkout step to `.github/workflows/update-locales.yaml` - Uses `actions/checkout@v5` to checkout the repository before referencing the local custom action This is a minimal fix that follows GitHub Actions best practices. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5938-fix-Add-checkout-step-before-using-local-action-in-update-locales-workflow-2846d73d365081cfb720ffaa528ce26e) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
update-localesworkflow was failing with the error:Ref: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18270266173/job/52011427608
Solution
Added a checkout step using
actions/checkout@v5before the "Setup Frontend" step. This ensures the repository code (including the local action definition) is available before GitHub Actions tries to use it.Changes
.github/workflows/update-locales.yamlactions/checkout@v5to checkout the repository before referencing the local custom actionThis is a minimal fix that follows GitHub Actions best practices.
┆Issue is synchronized with this Notion page by Unito