Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 6, 2025

Summary

This PR triggers test expectation regeneration through CI/CD pipelines.

Test plan

  • CI will run tests and update expectations automatically
  • Review generated changes for accuracy

┆Issue is synchronized with this Notion page by Unito

This empty commit is created to trigger CI/CD pipelines that will
regenerate test expectations and update snapshots as needed.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 6, 2025
Copy link

github-actions bot commented Oct 6, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/06/2025, 08:27:28 PM UTC

📈 Summary

  • Total Tests: 487
  • Passed: 453 ✅
  • Failed: 1 ❌
  • Flaky: 3 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 444 / ❌ 1 / ⚠️ 3 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link

github-actions bot commented Oct 6, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/06/2025, 08:01:11 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 6, 2025
Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to flip-flop

@christian-byrne
Copy link
Contributor Author

christian-byrne commented Oct 6, 2025

This seems to flip-flop

Oh true thank you - good catch. It should actually be showing the group in the minimap since that setting is default true, so this requires fixing rather than re-generating. I thought it was a threshold issue.

@christian-byrne
Copy link
Contributor Author

Replaced by #5962

christian-byrne added a commit that referenced this pull request Oct 7, 2025
Attempts to fix flakiness when groups are enabled on the minimap and the
screenshot is taken too early, before the render completes. See
[comment](#5942 (comment))
for more context.

May or may not solve the flakiness.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5962-wait-for-frame-on-group-creation-test-2856d73d365081f6a059ebfc5a03857c)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants