Skip to content

Style: Standardize icon use Part 1 #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Style: Standardize icon use Part 1 #5947

wants to merge 6 commits into from
+124 −119

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Oct 6, 2025 •
edited by sync-by-unito bot
Loading

Summary

Remove the mix of class based and component style icons in favor of just classes.

Changes

  • What: Migrate existing lucide icons

Review Focus

What differs between the icons before and now?

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/07/2025, 11:00:30 PM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

🎭 Playwright Test Results

✅ All tests passed!

⏰ Completed at: 10/07/2025, 11:09:28 PM UTC

📈 Summary

  • Total Tests: 9
  • Passed: 9 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 0

📊 Test Reports by Browser

  • ❌ chromium: Deployment failed
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@DrJKL DrJKL force-pushed the drjkl/just-icons-stuff branch from 8e701f9 to 3f19144 Compare October 6, 2025 23:28
@DrJKL DrJKL added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Oct 6, 2025
@DrJKL DrJKL marked this pull request as ready for review October 7, 2025 00:28
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 7, 2025
@DrJKL DrJKL requested a review from christian-byrne October 7, 2025 00:32
Myestery
Myestery reviewed Oct 7, 2025
View reviewed changes
@DrJKL DrJKL added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Oct 7, 2025
arjansingh
arjansingh previously approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@arjansingh arjansingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. but you need to verify that README comment and put what style we want and what style we don't want. Otherwise, the AI tooling will be prone to putting the wrong format in.

@DrJKL DrJKL force-pushed the drjkl/just-icons-stuff branch from 8fec65d to 92f0525 Compare October 7, 2025 16:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 7, 2025
@DrJKL DrJKL added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Oct 7, 2025
@DrJKL DrJKL requested a review from Myestery October 7, 2025 19:54
@DrJKL DrJKL requested a review from arjansingh October 7, 2025 19:54
@DrJKL DrJKL force-pushed the drjkl/just-icons-stuff branch from cca89ad to 629fc82 Compare October 7, 2025 19:55
@christian-byrne christian-byrne added the claude-review Add to trigger a PR code review from Claude Code label Oct 7, 2025
@DrJKL DrJKL force-pushed the drjkl/just-icons-stuff branch from 78e5915 to d1545f1 Compare October 7, 2025 22:35
@DrJKL DrJKL force-pushed the drjkl/just-icons-stuff branch from 8c45001 to 3ca6d5d Compare October 7, 2025 22:58
@DrJKL DrJKL added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtydhr88 jtydhr88 Awaiting requested review from jtydhr88 jtydhr88 is a code owner

@viva-jinyi viva-jinyi Awaiting requested review from viva-jinyi viva-jinyi is a code owner

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered is a code owner

@christian-byrne christian-byrne Awaiting requested review from christian-byrne

@Myestery Myestery Awaiting requested review from Myestery Myestery is a code owner

@arjansingh arjansingh Awaiting requested review from arjansingh arjansingh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@arjansingh arjansingh

@Myestery Myestery

@webfiltered webfiltered

Labels
claude-review Add to trigger a PR code review from Claude Code New Browser Test Expectations New browser test screenshot should be set by github action size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DrJKL @arjansingh @Myestery @christian-byrne @webfiltered