-
Notifications
You must be signed in to change notification settings - Fork 377
refactor: Reorganize GitHub Actions for better reusability #5949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snomiao
wants to merge
6
commits into
main
Choose a base branch
from
sno-setup-frontend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+177
−266
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a1a5dd0
refactor: reorganize GitHub Actions for better reusability
snomiao bca84ef
fix: correct blob report output path for new workflow structure
snomiao a2388ff
fix: typo
snomiao 0589f0f
improve: add error handling for devtools copy in setup-comfyui-server
snomiao ce3218d
refactor: improve .cache directory caching strategy
snomiao 4bc799b
Merge branch 'main' into sno-setup-frontend
snomiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
name: Setup ComfyUI Server | ||
description: 'Setup ComfyUI server for continuous integration (with ComfyUI_devtools node installed)' | ||
inputs: | ||
extra_server_params: | ||
description: 'Additional parameters to pass to ComfyUI server' | ||
required: false | ||
default: '' | ||
launch_server: | ||
description: 'Whether to launch the server after setup' | ||
required: false | ||
default: 'true' | ||
runs: | ||
using: 'composite' | ||
steps: | ||
# Note: this workflow assume frontend repo is checked out and is built in ../dist | ||
|
||
# Checkout ComfyUI repo, install the dev_tools node and start server | ||
- name: Checkout ComfyUI | ||
uses: actions/checkout@v5 | ||
with: | ||
repository: 'comfyanonymous/ComfyUI' | ||
path: 'ComfyUI' | ||
|
||
- name: Install ComfyUI_devtools from frontend repo | ||
shell: bash | ||
run: | | ||
mkdir -p ComfyUI/custom_nodes/ComfyUI_devtools | ||
if ! cp -r ./tools/devtools/* ComfyUI/custom_nodes/ComfyUI_devtools/; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So this means the frontend isn't under |
||
echo "::error::Failed to copy ComfyUI_devtools from ./tools/devtools/" | ||
echo "::error::This action assumes the ComfyUI_frontend repository is checked out in the current working directory." | ||
echo "::error::Please ensure you have run 'actions/checkout@v5' before calling this action." | ||
exit 1 | ||
fi | ||
|
||
- name: Setup Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
|
||
- name: Install Python requirements | ||
shell: bash | ||
working-directory: ComfyUI | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu | ||
pip install -r requirements.txt | ||
pip install wait-for-it | ||
|
||
- name: Start ComfyUI server | ||
if: ${{ inputs.launch_server == 'true' }} | ||
shell: bash | ||
working-directory: ComfyUI | ||
run: | | ||
python main.py --cpu --multi-user --front-end-root ../dist ${{ inputs.extra_server_params }} & | ||
wait-for-it --service 127.0.0.1:8188 -t 600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.