feat(api-nodes-pricing): add prices for ByteDance seedance-1-0-pro-fast model #7026
Conversation
dosubot
bot
added
the
size:S
📝 WalkthroughWalkthroughThe change adds pricing support for a new model variant Changes
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/28/2025, 04:24:48 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/28/2025, 04:34:04 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 949 kB (baseline 949 kB) • 🔴 +189 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 17 added / 17 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/composables/node/useNodePricing.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json
Files:
src/composables/node/useNodePricing.ts
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursorrules)
Use es-toolkit for utility functions
Files:
src/composables/node/useNodePricing.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
Use TypeScript for type safety
**/*.{ts,tsx}: Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Files:
src/composables/node/useNodePricing.ts
**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committing
Files:
src/composables/node/useNodePricing.ts
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/composables/node/useNodePricing.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/composables/node/useNodePricing.ts
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/composables/node/useNodePricing.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/composables/node/useNodePricing.ts
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
UsedefaultsByInstallVersionproperty for gradual feature rollout based on version in settings configuration
Files:
src/composables/node/useNodePricing.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/node/useNodePricing.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/composables/node/useNodePricing.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/composables/node/useNodePricing.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/composables/node/useNodePricing.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/composables/node/useNodePricing.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: collect
- GitHub Check: lint-and-format
- GitHub Check: test
🔇 Additional comments (1)
src/composables/node/useNodePricing.ts (1)
146-152: Correct priority order for model variant matching.The modelKey resolution correctly checks for
seedance-1-0-pro-fastbeforeseedance-1-0-pro. This order is critical because the substring matching would incorrectly match the fast variant to the regular pro variant if checked in reverse order.
| 'seedance-1-0-pro-fast': { | ||
| '480p': [0.09, 0.1], | ||
| '720p': [0.21, 0.23], | ||
| '1080p': [0.47, 0.49] | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, let's examine the useNodePricing.ts file to see the full context
wc -l src/composables/node/useNodePricing.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 113
🏁 Script executed:
#!/bin/bash
# Read the relevant sections of the file
sed -n '130,160p' src/composables/node/useNodePricing.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 820
🏁 Script executed:
#!/bin/bash
# Let's check if there are any comments or documentation about pricing in the file
head -50 src/composables/node/useNodePricing.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1561
🏁 Script executed:
#!/bin/bash
# Search for any references to ByteDance or seedance pricing documentation
rg -n "seedance|ByteDance|pricing" src/composables/node/useNodePricing.ts | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1095
🏁 Script executed:
#!/bin/bash
# Check if there are any test files or related documentation
fd -e test.ts -e spec.ts -e test.js useNodePricingRepository: Comfy-Org/ComfyUI_frontend
Length of output: 124
🏁 Script executed:
#!/bin/bash
# Let's check the git history or PR context if available
git log --oneline -n 20 src/composables/node/useNodePricing.ts 2>/dev/null | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 156
🏁 Script executed:
#!/bin/bash
# Let's examine the test file to see if pricing values are tested
cat -n tests-ui/tests/composables/node/useNodePricing.test.ts | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3846
🏁 Script executed:
#!/bin/bash
# Search for seedance tests specifically
rg -n "seedance-1-0-pro-fast" tests-ui/tests/composables/node/useNodePricing.test.ts -A 3 -B 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
#!/bin/bash
# Let's get more details about the commit
git show cfa9369c --statRepository: Comfy-Org/ComfyUI_frontend
Length of output: 50383
🏁 Script executed:
#!/bin/bash
# Search for seedance tests in the test file more thoroughly
rg -n "seedance" tests-ui/tests/composables/node/useNodePricing.test.ts -C 5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3286
🏁 Script executed:
#!/bin/bash
# Check if there are any recent changes to ByteDance pricing documentation or links
rg -n "seedance|ByteDance" . --type ts -g "!node_modules" -g "!dist" | head -30Repository: Comfy-Org/ComfyUI_frontend
Length of output: 2841
🏁 Script executed:
#!/bin/bash
# Verify the complete pricing entry structure in context
sed -n '125,160p' src/composables/node/useNodePricing.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1102
🏁 Script executed:
#!/bin/bash
# Search for any tests that might cover seedance-1-0-pro-fast specifically
rg -n "seedance-1-0-pro-fast" tests-ui/ -C 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
#!/bin/bash
# Check the pricing calculation logic to understand how duration/resolution are applied
sed -n '156,200p' src/composables/node/useNodePricing.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1452
Add test coverage for seedance-1-0-pro-fast pricing; verify values against ByteDance documentation.
The pricing entry is well-structured and properly integrated. The seedance-1-0-pro-fast tier (480p: [$0.09, $0.10], 720p: [$0.21, $0.23], 1080p: [$0.47, $0.49]) is positioned reasonably between the standard pro (roughly 2.5× more expensive) and lite variants.
However, tests exist for seedance-1-0-pro and seedance-1-0-lite in the test file, but there are no tests for the new seedance-1-0-pro-fast variant. Add test cases to verify pricing calculations for this tier to match the coverage of other ByteDance models.
Additionally, verify these pricing values against official ByteDance documentation or the referenced external PR (comfyanonymous/ComfyUI#10947) to ensure accuracy.
🤖 Prompt for AI Agents
In src/composables/node/useNodePricing.ts around lines 134 to 138, add unit
tests for the new seedance-1-0-pro-fast pricing similar to the existing tests
for seedance-1-0-pro and seedance-1-0-lite: create test cases that assert the
stored price arrays for '480p', '720p', and '1080p' equal [0.09,0.10],
[0.21,0.23], and [0.47,0.49] respectively, and assert any derived calculation
helpers yield expected outputs; place these tests alongside the existing
ByteDance model tests in the same test file and run them, and before committing
confirm the numeric values match ByteDance official docs or the referenced PR
(https://github.com/comfyanonymous/ComfyUI/pull/10947) and update tests if the
authoritative source differs.
christian-byrne
added
needs-backport
christian-byrne
deleted the
feat/api-nodes/pricing/bytedance-pro-fast
branch
…st model (#7026) ## Summary Price badges for this PR: comfyanonymous/ComfyUI#10947 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7026-feat-api-nodes-pricing-add-prices-for-ByteDance-seedance-1-0-pro-fast-model-2b96d73d365081eeb7f7de1dc892389b) by [Unito](https://www.unito.io)
…st model (#7026) ## Summary Price badges for this PR: comfyanonymous/ComfyUI#10947 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7026-feat-api-nodes-pricing-add-prices-for-ByteDance-seedance-1-0-pro-fast-model-2b96d73d365081eeb7f7de1dc892389b) by [Unito](https://www.unito.io)
github-actions
bot
removed
the
needs-backport
…e seedance-1-0-pro-fast model (#7029) Backport of #7026 to `core/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7029-backport-core-1-33-feat-api-nodes-pricing-add-prices-for-ByteDance-seedance-1-0-pro-f-2b96d73d365081e48660fa00f236fae9) by [Unito](https://www.unito.io) Co-authored-by: Alexander Piskun <[email protected]>
…ce seedance-1-0-pro-fast model (#7030) Backport of #7026 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7030-backport-cloud-1-33-feat-api-nodes-pricing-add-prices-for-ByteDance-seedance-1-0-pro--2b96d73d365081ff9e4feb7b1d147dc5) by [Unito](https://www.unito.io) Co-authored-by: Alexander Piskun <[email protected]>
Summary
Price badges for this PR: comfyanonymous/ComfyUI#10947
┆Issue is synchronized with this Notion page by Unito