[feat] Replace NodeOptions with PrimeVue ContextMenu #7114
+361
−643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom Popover-based node context menu with PrimeVue ContextMenu: - Add NodeContextMenu.vue using PrimeVue ContextMenu component - Rename SubmenuPopover.vue to ColorPickerMenu.vue (specialized for color picker) - Delete NodeOptions.vue, MenuOptionItem.vue, and useSubmenuPositioning.ts - Wire up context menu converter in useMoreOptionsMenu.ts - Update tests to use hover instead of click for submenus This migration provides: - Native PrimeVue submenu support with proper keyboard navigation - Constrained menu dimensions with overflow scrolling - Cleaner component architecture with less custom code
Myestery
requested review from
a team,
KarryCharon,
Yorha4D,
shinshin86 and
viva-jinyi
as code owners
dosubot
bot
added
the
size:XXL
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright Test Results⏰ Completed at: 12/03/2025, 01:23:41 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/03/2025, 01:15:17 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NodeContextMenu.vueusing PrimeVue ContextMenu component with native submenu supportSubmenuPopover.vuetoColorPickerMenu.vue(specialized for color picker)NodeOptions.vue,MenuOptionItem.vue,useSubmenuPositioning.tsuseMoreOptionsMenu.tsDependencies
This PR depends on #7113 - the context menu converter infrastructure PR. It should be merged after that PR.
Benefits
Test plan
Screenshots
(Menu UI should look the same, with improved submenu behavior)
┆Issue is synchronized with this Notion page by Unito