-
Notifications
You must be signed in to change notification settings - Fork 433
feat: replace GET /queue and /history calls with /jobs #7125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b733b88
[feat] Add Jobs API integration with memory optimization and lazy loa…
ric-yu 5cd07fd
refactor: remove extra function
ric-yu fd13755
lazy fetch exec error for dialog
ric-yu 19b31e5
use execution_error field
ric-yu 4c22b2d
remove file ext refactor
ric-yu b9537d3
remove dummy type; revert queuestore
ric-yu 2aa2be6
fix cloud ordering
ric-yu f556795
address coderabbit comments, fix workflow id on popover
ric-yu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update_timeandlast_state_updateare not defined inJobListItemschema.The
makeTaskhelper usesupdate_time(line 44) andlast_state_update(line 49), but these fields are not defined inzRawJobListIteminjobTypes.ts. While.passthrough()allows extra fields at runtime, TypeScript won't recognize them, and the explicit type annotation on line 43-44 requiringupdate_timewill cause type errors.Either add these fields to the
zRawJobListItemschema if they're part of the API, or remove them from the story helpers if they're not needed.🤖 Prompt for AI Agents