feat: Migrate to Jobs API (PR 2 of 3) #7170
Open
+1,108
−2,809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
bot
added
the
size:XXL
🎭 Playwright Test Results⏰ Completed at: 12/05/2025, 10:11:45 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/05/2025, 10:02:44 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
ric-yu
force-pushed
the
jobs-api-pr1-infrastructure
branch
from
de0d169 to
5cb2579
Compare
ric-yu
force-pushed
the
jobs-api-pr2-migration
branch
from
a1869fe to
d38a8a6
Compare
ric-yu
force-pushed
the
jobs-api-pr1-infrastructure
branch
from
5cb2579 to
0a619ec
Compare
ric-yu
force-pushed
the
jobs-api-pr2-migration
branch
2 times, most recently
from
eb0ca33 to
5ef30f3
Compare
ric-yu
force-pushed
the
jobs-api-pr2-migration
branch
from
b457e64 to
1b94732
Compare
Adds Jobs API types, fetchers, and new API methods without breaking existing code. This is the foundation for migrating from legacy /history and /queue endpoints to the unified /jobs endpoint. New files: - src/platform/remote/comfyui/jobs/types/jobTypes.ts - Zod schemas for Jobs API - src/platform/remote/comfyui/jobs/fetchers/fetchJobs.ts - Fetchers for /jobs endpoint - src/platform/remote/comfyui/jobs/index.ts - Barrel exports - tests-ui/tests/platform/remote/comfyui/jobs/fetchers/fetchJobs.test.ts API additions (non-breaking): - api.getQueueFromJobsApi() - Queue from /jobs endpoint - api.getHistoryFromJobsApi() - History from /jobs endpoint - api.getJobDetail() - Full job details including workflow and outputs Part of Jobs API migration. See docs/JOBS_API_MIGRATION_PLAN.md for details. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds Jobs API types, fetchers, and new API methods without breaking existing code. This is the foundation for migrating from legacy /history and /queue endpoints to the unified /jobs endpoint. New files: - src/platform/remote/comfyui/jobs/types/jobTypes.ts - Zod schemas for Jobs API - src/platform/remote/comfyui/jobs/fetchers/fetchJobs.ts - Fetchers for /jobs endpoint - src/platform/remote/comfyui/jobs/index.ts - Barrel exports - tests-ui/tests/platform/remote/comfyui/jobs/fetchers/fetchJobs.test.ts API additions (non-breaking): - api.getQueueFromJobsApi() - Queue from /jobs endpoint - api.getHistoryFromJobsApi() - History from /jobs endpoint - api.getJobDetail() - Full job details including workflow and outputs Part of Jobs API migration. See docs/JOBS_API_MIGRATION_PLAN.md for details. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This PR switches the frontend from legacy /history and /queue endpoints to the unified /jobs API. Key changes: - Rewrite TaskItemImpl in queueStore.ts to wrap JobListItem - Update api.ts getQueue()/getHistory() to use Jobs API - Update all queue composables (useJobList, useJobMenu, useResultGallery) - Update useJobErrorReporting to use execution_error.exception_message - Update JobGroupsList.vue workflowId access - Update reconciliation.ts to work with JobListItem - Update all related tests Breaking changes: - getQueue() now returns JobListItem[] instead of legacy tuple format - getHistory() now returns JobListItem[] instead of HistoryTaskItem[] - TaskItemImpl.outputs now lazily loads via loadFullOutputs() Part of Jobs API migration. Depends on PR 1 (jobs-api-pr1-infrastructure). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ric-yu
force-pushed
the
jobs-api-pr2-migration
branch
from
1b94732 to
f1999c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate frontend from legacy
/history,/history_v2, and/queueendpoints to the unified/jobsAPI with memory optimization and lazy loading.This is PR 2 of 3 - Core migration, depends on PR 1.
Changes
What:
api.getQueue()andapi.getHistory()implementations to use Jobs API fetchers/jobs/{id}endpoint inuseJobMenuTaskItemImplclass wrappingJobListItemfor queue store compatibilityreconcileHistorytoreconcileJobsfor clarityexecution_start_timeandexecution_end_timefrom API for execution timingworkflowIdfrom job instead of nestedworkflow.iduseJobMenuto fetch job details on demand (openJobWorkflow,exportJobWorkflow)Breaking: Requires backend Jobs API support (ComfyUI with
/jobsendpoint)Review Focus
useJobMenu:openJobWorkflowandexportJobWorkflownow fetch from API on demand instead of accessingtaskRef.workflowTaskItemImplwrapper: AdaptsJobListItemto existing queue store interfaceexecution_errorfield from API for rich error dialogsFiles Changed
src/scripts/api.ts- UpdatedgetQueue()andgetHistory()to use Jobs APIsrc/stores/queueStore.ts- AddedTaskItemImpl, updated to useJobListItemsrc/composables/useJobMenu.ts- Lazy loading for workflow accesssrc/composables/useJobList.ts- Updated typesDependencies
Next PR
┆Issue is synchronized with this Notion page by Unito