-
Notifications
You must be signed in to change notification settings - Fork 433
chore: Remove legacy history code (PR 3 of 3) #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jobs-api-pr2-migration
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright Test Results⏰ Completed at: 12/05/2025, 01:01:48 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/05/2025, 12:52:14 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
a1869fe to
d38a8a6
Compare
0386c8c to
07d20e6
Compare
d38a8a6 to
eb0ca33
Compare
07d20e6 to
5b2a67b
Compare
eb0ca33 to
5ef30f3
Compare
5b2a67b to
ce37f14
Compare
Removes legacy history API code and cleans up unused types from apiSchema.ts now that the migration to Jobs API is complete. Deleted files: - src/platform/remote/comfyui/history/* (except reconciliation.ts) - src/platform/workflow/cloud/getWorkflowFromHistory.ts - src/platform/workflow/cloud/index.ts - browser_tests/fixtures/utils/taskHistory.ts - tests-ui/fixtures/history*.ts - tests-ui/tests/platform/remote/comfyui/history/** - tests-ui/tests/platform/workflow/cloud/getWorkflowFromHistory.test.ts Cleaned up apiSchema.ts: - Removed legacy tuple types (zQueueIndex, zExtraData, etc.) - Removed RunningTaskItem, PendingTaskItem, HistoryTaskItem, TaskItem - Kept only types still in use (WebSocket messages, TaskOutput, etc.) Part of Jobs API migration. Depends on PR 2 (jobs-api-pr2-migration). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ce37f14 to
5cba4ab
Compare
Summary
Remove legacy history code that is no longer needed after migrating to the Jobs API.
This is PR 3 of 3 - Cleanup only, depends on PR 2.
Changes
What:
/historyand/history_v2fetchers and adaptersHistoryTaskItem,RunningTaskItem,PendingTaskItem, etc.)getWorkflowFromHistorywrapper (replaced by directfetchJobDetail+extractWorkflow)apiSchema.tsNon-breaking: Only removes dead code after migration
Files Deleted
Legacy History Module
src/platform/remote/comfyui/history/(entire directory)adapters/v2ToV1Adapter.tsfetchers/fetchHistoryV1.tsfetchers/fetchHistoryV2.tstypes/historyV1Types.tstypes/historyV2Types.tsindex.tsLegacy Workflow Helper
src/platform/workflow/cloud/getWorkflowFromHistory.tssrc/platform/workflow/cloud/index.tsTest Fixtures
tests-ui/fixtures/historyFixtures.tstests-ui/fixtures/historySortingFixtures.tsbrowser_tests/fixtures/utils/taskHistory.tsLegacy Tests
tests-ui/tests/platform/remote/comfyui/history/(all tests)Files Modified
src/schemas/apiSchema.ts- Removed unused legacy types:zQueueIndex,zExtraDataRunningTaskItem,PendingTaskItem,HistoryTaskItem,TaskItemDependencies
┆Issue is synchronized with this Notion page by Unito