[demo] PostHog Feature Flag Integration for Run Button Experiment #7172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of #6945 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6968-backport-cloud-1-33-feat-open-template-via-URL-in-linear-mode-2b76d73d365081c4b5d5c0727106fc29) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]>
…presence of missing nodes (#6972) ## Summary Backport of #6965 onto cloud/1.33 (clean cherry-pick of 83f0449). ## Testing - pnpm typecheck ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6972-backport-cloud-1-33-fix-don-t-use-registry-when-only-checking-for-presence-of-missing--2b86d73d36508150af46da84e754df3a) by [Unito](https://www.unito.io)
## Summary Backport of #6950 onto cloud/1.33 (clean cherry-pick of 4b87b1f). ## Testing - pnpm typecheck ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6983-backport-cloud-1-33-fix-remove-LOD-from-vue-nodes-2b86d73d36508119bafbc5a5a6a5ad42) by [Unito](https://www.unito.io) Co-authored-by: Simula_r <[email protected]> Co-authored-by: github-actions <[email protected]>
…normalization (#6978) ## Summary Backport of #6966 onto cloud/1.33. - cherry-picked 29dbfa3 - accepted upstream snapshot updates (only zoomed-in ctrl+shift PNG conflicted) ## Testing - pnpm typecheck ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6978-backport-cloud-1-33-fix-Vue-Node-Litegraph-node-height-offset-normalization-2b86d73d365081a19a81f4fac0fd2e91) by [Unito](https://www.unito.io) Co-authored-by: github-actions <[email protected]>
Backport of #6999 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7003-backport-cloud-1-33-fix-add-filter-for-combo-widgets-2b86d73d3650818daa83c680abf3b5c4) by [Unito](https://www.unito.io) Co-authored-by: Johnpaul Chiwetelu <[email protected]>
…7011) Backport of #7008 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7011-backport-cloud-1-33-Remove-app-graph-usage-from-widgetInput-code-2b86d73d365081de9460daecfde4bb87) by [Unito](https://www.unito.io) Co-authored-by: AustinMroz <[email protected]>
… for Safari compatibility (#7012) Backport of #7006 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7012-backport-cloud-1-33-fix-Re-encode-cloud-subscription-video-to-VP9-for-Safari-compatib-2b86d73d365081a0be8ac57b8afce8a8) by [Unito](https://www.unito.io) Co-authored-by: Johnpaul Chiwetelu <[email protected]>
…d jobs in cloud (#7013) Backport of #6895 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7013-backport-cloud-1-33-feat-Show-Finished-in-duration-for-completed-jobs-in-cloud-2b86d73d365081419f90ee82f5e45253) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <[email protected]> Co-authored-by: Claude <[email protected]>
…ce seedance-1-0-pro-fast model (#7030) Backport of #7026 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7030-backport-cloud-1-33-feat-api-nodes-pricing-add-prices-for-ByteDance-seedance-1-0-pro--2b96d73d365081ff9e4feb7b1d147dc5) by [Unito](https://www.unito.io) Co-authored-by: Alexander Piskun <[email protected]>
Backport of #7047 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7052-backport-cloud-1-33-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d365081da9bb6cb1859c7bf5a) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]>
… instead of filename on cloud (#7046) Backport of #7005 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7046-backport-cloud-1-33-fix-loader-node-widget-value-shows-placeholder-instead-of-filename-2bb6d73d365081bd9531c08bbaeb8634) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]>
… only (#7063) (#7068) ## Summary - Backport of #7063 to cloud/1.33 - Simplifies Vue node resize to bottom-right corner only Cherry-picked from d76c59c ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7068-backport-cloud-1-33-Simplify-Vue-node-resize-to-bottom-right-corner-only-7063-2bc6d73d36508149bd85c3ae534387b6) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
…esize (#7071) Backport of #7064 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7071-backport-cloud-1-33-fix-Prevent-drag-activation-during-Vue-node-resize-2bc6d73d36508129b6d4ee43e79de500) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]> Co-authored-by: DrJKL <[email protected]>
…1 video model (#7079) Backport of #7077 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7079-backport-cloud-1-33-feat-api-nodes-pricing-add-prices-for-Kling-O1-video-model-2bc6d73d365081c4ad83d1c5317a9135) by [Unito](https://www.unito.io) Co-authored-by: Alexander Piskun <[email protected]>
…n for Windows compatibility (#7090) Backport of #7087 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7090-backport-cloud-1-33-fix-normalize-path-separators-in-comfyAPIPlugin-for-Windows-compat-2bd6d73d365081228497fa23b58b8978) by [Unito](https://www.unito.io) Co-authored-by: Terry Jia <[email protected]>
…o 10min (from 30s) (#7111) Backport of #7100 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7111-backport-cloud-1-33-cloud-increase-feature-flag-polling-interval-to-10min-from-30s-2be6d73d3650817ea746fa49eb896a2d) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <[email protected]> Co-authored-by: Alexander Brown <[email protected]>
…ature flags (#7143) Feature flags for model upload button and asset update options now check remote config from `/api/features` first, falling back to websocket feature flags. - **What**: Added `model_upload_button_enabled` and `asset_update_options_enabled` to `RemoteConfig` type - **What**: Updated feature flag getters to prioritize remote config over websocket flags - **Why**: Enables dynamic feature control without requiring websocket connection, consistent with other feature flags pattern - Pattern consistency with other remote config feature flags - Proper fallback behavior when remote config is unavailable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7143-feat-Add-remote-config-support-for-model-upload-and-asset-update-feature-flags-2bf6d73d3650819cb364f0ab69d77dd0) by [Unito](https://www.unito.io) Co-authored-by: Claude <[email protected]>
- Add FeatureFlaggedRunButton wrapper component - Add ExperimentalRunButton with JSON-driven styling - Extend useFeatureFlags to support remoteConfig and variant payloads - Support 4 experimental button variants (bold-gradient, animated, playful, minimal) - Add documentation for feature flag payload structure NOTE: This is a DEMO and should NOT be merged
luke-mino-altherr
added
enhancement
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
- Wrap SubscribeToRunButton with FeatureFlaggedRunButton for cloud users - Enable experimental button variants for cloud subscription flow - Maintains existing behavior: ComfyQueueButton (with subscription) or SubscribeToRunButton (without)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds PostHog feature flag integration to demonstrate multivariant experiments on the Run button without code deploys. The feature flag system allows switching between the original button (control) and experimental variants driven by JSON payloads from the backend.
Changes
bold-gradient: Animated gradient backgroundanimated: Pulsing animation with pill shapeplayful: Sparkle effects with yellow-orange gradientminimal: Clean white design with subtle bordersFeature Flag Structure
The feature flag
demo_run_button_experiment(ordemo-run-button-experiment) accepts:false/null/undefined: Shows original SplitButton (control){ variant: string, payload: {...} }: Shows experimental buttonSee
FEATURE_FLAG_PAYLOAD.mdfor complete payload documentation.Review Focus
This is a DEMO PR and should NOT be merged. It's for demonstrating PostHog feature flag capabilities to the team.
┆Issue is synchronized with this Notion page by Unito