-
Notifications
You must be signed in to change notification settings - Fork 472
feat: add live preview method setting for prompt execution #7385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a new Comfy.Execution.PreviewMethod setting (options: default, none, auto, latent2rgb, taesd); adds localization, schema/type exports, registers it in core settings, and forwards a chosen preview method from the queue flow to the backend when explicitly set. Changes
Sequence Diagram(s)mermaid ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used📓 Path-based instructions (6)src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx,vue,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (3)📚 Learning: 2025-12-09T03:39:54.501ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
📚 Learning: 2025-12-09T04:35:43.971ZApplied to files:
🧬 Code graph analysis (1)src/scripts/api.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (3)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/12/2025, 12:25:15 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 12/12/2025, 12:34:41 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.24 MB (baseline 3.23 MB) • 🔴 +751 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 987 kB (baseline 987 kB) • 🔴 +378 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 178 kB (baseline 178 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
c9116b2 to
d7d01f7
Compare
ed73c36 to
364c9ce
Compare
Allow users to override the preview method (default/none/auto/latent2rgb/taesd) from frontend settings. 'default' uses the server CLI setting. - Add PreviewMethod type using zod schema in apiSchema.ts - Add Comfy.Execution.PreviewMethod setting with combo options - Read preview method setting inside queuePrompt() for centralized access - Send preview_method in extra_data when not 'default'
364c9ce to
b329abd
Compare
|
1 similar comment
|
Add frontend setting to override live preview method per prompt execution. - **What**: New setting `Comfy.Execution.PreviewMethod` allows users to override preview method (default/none/auto/latent2rgb/taesd) from frontend. Applied to Queue Prompt, Queue Front, Run Selected Nodes, and Auto Queue. - **Dependencies**: Requires backend support from Comfy-Org/ComfyUI#11261 - `'default'` option does not send `preview_method` to backend (uses server CLI setting) - Legacy UI intentionally not modified (deprecated, maintains backward compatibility) - `versionAdded: '1.35.3'` assigned tentatively; adjust as needed for actual release version ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7385-feat-add-live-preview-method-setting-for-prompt-execution-2c66d73d365081759c9cebaec29f451c) by [Unito](https://www.unito.io)
… execution (#7521) ## Summary Backport of #7385 to core/1.34. Add frontend setting to override live preview method per prompt execution. - **What**: New setting `Comfy.Execution.PreviewMethod` allows users to override preview method (default/none/auto/latent2rgb/taesd) from frontend. ## Conflict Resolution - `src/schemas/apiSchema.ts`: Kept both `Comfy.Queue.ImageFit` (target branch) and `Comfy.Execution.PreviewMethod` (PR addition) Co-authored-by: Dr.Lt.Data <[email protected]>
…#7385) ## Summary Add frontend setting to override live preview method per prompt execution. ## Changes - **What**: New setting `Comfy.Execution.PreviewMethod` allows users to override preview method (default/none/auto/latent2rgb/taesd) from frontend. Applied to Queue Prompt, Queue Front, Run Selected Nodes, and Auto Queue. - **Dependencies**: Requires backend support from Comfy-Org/ComfyUI#11261 ## Review Focus - `'default'` option does not send `preview_method` to backend (uses server CLI setting) - Legacy UI intentionally not modified (deprecated, maintains backward compatibility) - `versionAdded: '1.35.3'` assigned tentatively; adjust as needed for actual release version ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7385-feat-add-live-preview-method-setting-for-prompt-execution-2c66d73d365081759c9cebaec29f451c) by [Unito](https://www.unito.io)
## Summary Add frontend setting to override live preview method per prompt execution. ## Changes - **What**: New setting `Comfy.Execution.PreviewMethod` allows users to override preview method (default/none/auto/latent2rgb/taesd) from frontend. Applied to Queue Prompt, Queue Front, Run Selected Nodes, and Auto Queue. - **Dependencies**: Requires backend support from Comfy-Org/ComfyUI#11261 ## Review Focus - `'default'` option does not send `preview_method` to backend (uses server CLI setting) - Legacy UI intentionally not modified (deprecated, maintains backward compatibility) - `versionAdded: '1.35.3'` assigned tentatively; adjust as needed for actual release version ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7385-feat-add-live-preview-method-setting-for-prompt-execution-2c66d73d365081759c9cebaec29f451c) by [Unito](https://www.unito.io)
Summary
Add frontend setting to override live preview method per prompt execution.
Changes
Comfy.Execution.PreviewMethodallows users to override preview method (default/none/auto/latent2rgb/taesd) from frontend. Applied to Queue Prompt, Queue Front, Run Selected Nodes, and Auto Queue.Review Focus
'default'option does not sendpreview_methodto backend (uses server CLI setting)versionAdded: '1.35.3'assigned tentatively; adjust as needed for actual release version┆Issue is synchronized with this Notion page by Unito