Integrated tab bar UI elements #7853
Conversation
- Add 'Comfy.UI.TabBarLayout' setting with Default/Integrated options - Move Help & User controls to tab bar when Integrated mode is enabled - Extract help center logic into shared useHelpCenter composable
📝 WalkthroughWalkthroughAdds a Tab Bar Layout setting and integrates Help Center controls into an optional integrated tab bar; centralizes Help Center UI into a new composable and popup component, updates store/schema/locales, and applies conditional rendering across topbar and sidebar components. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant UI as Topbar / Sidebar
participant Composable as useHelpCenter
participant Store as helpCenterStore
participant Popups as HelpCenterPopups
participant Dialog as DialogService
User->>UI: click help control
UI->>Composable: toggleHelpCenter(location)
Composable->>Store: toggle(location) / set triggerLocation
Store-->>Composable: isVisible / triggerLocation
Composable->>Popups: show Help Center (Teleport into canvas)
Popups-->>User: render popup
alt User dismisses WhatsNew
User->>Popups: dismiss
Popups->>Composable: handleWhatsNewDismissed()
Composable->>Dialog: maybe show conflict modal (async)
Dialog-->>User: show conflict modal (if needed)
end
Possibly related PRs
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/09/2026, 03:05:13 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 01/09/2026, 03:10:27 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.24 MB (baseline 3.24 MB) • 🔴 +365 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1.05 MB (baseline 1.05 MB) • 🔴 +4.56 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 302 kB (baseline 302 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 198 kB (baseline 198 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.19 MB (baseline 9.19 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 16 added / 16 removed |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
pythongosssss
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:XL
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/sidebar/SidebarHelpCenterIcon.vue (1)
25-44: Use design system color token instead of hardcoded color, and remove!importantif possible.The hardcoded color
#ff3b30should be replaced with a design system token. The closest available semantic colors are--color-danger-200(#d62952) or--color-error-text(#ff4444). Determine which is appropriate for your notification indicator.For the
!importanton line 42, try removing it by adjusting the CSS selector specificity to override PrimeVue's defaults without the!importantflag.Current code
:deep(.p-badge) { background: #ff3b30; color: #ff3b30; min-width: 8px; height: 8px; padding: 0; border-radius: 9999px; font-size: 0; margin-top: 4px; margin-right: 4px; border: none; outline: none; box-shadow: none; } :deep(.p-badge.p-badge-dot) { width: 8px !important; }
🤖 Fix all issues with AI Agents
In @src/components/helpcenter/HelpCenterPopups.vue:
- Around line 44-50: The backdrop element rendered inside Teleport uses
position: absolute which can fail to cover the viewport; update the styling for
the backdrop (the div with class "help-center-backdrop" rendered when
isHelpCenterVisible and the similar backdrop used around lines 74-82) to use
position: fixed instead of absolute so it always spans the full viewport
regardless of document flow or scrolling; locate the CSS rules for
.help-center-backdrop (and any duplicate backdrop class/inline style in the same
component) and change position to fixed, keeping existing sizing
(top/left/right/bottom or width/height) and z-index intact.
- Around line 73-134: Replace hardcoded CSS in HelpCenterPopups.vue by switching
positioning and z-index to Tailwind/design tokens and moving animations to
shared CSS: update usages of .help-center-backdrop and .help-center-popup
(including variants .sidebar-left, .sidebar-right, .topbar-right,
.small-sidebar) to use Tailwind utility classes for absolute positioning,
spacing and z-index tokens instead of 9999/10000; if Tailwind's built-in
animations cover the behavior, replace the local @keyframes slideInUp and
slideInDown with Tailwind animation classes, otherwise move these keyframes into
the shared design-system CSS (or an @apply-enabled file) and reference them via
a named utility or class so the component contains only utility classes.
In @src/composables/useHelpCenter.ts:
- Around line 85-89: Wrap the onMounted initialization of the release store in a
try/catch: call releaseStore.initialize() inside try, handle failures in catch
by logging the error (e.g., console.error or your app logger), optionally
surface a user-friendly fallback (e.g., display a toast or set a local error
state) and avoid rethrowing so the unhandled error doesn’t crash the app; update
the onMounted block that calls releaseStore.initialize() accordingly and include
references to the onMounted callback and releaseStore.initialize() so reviewers
can find the change.
- Around line 43-48: The telemetry event in toggleHelpCenter hardcodes button_id
to 'sidebar_help_center_toggled' which mislabels events when triggerFrom is
'topbar'; update toggleHelpCenter to derive the button_id from triggerFrom
(e.g., use a mapping or template like `${triggerFrom}_help_center_toggled`)
before calling useTelemetry()?.trackUiButtonClicked, and keep the
helpCenterStore.toggle(triggerFrom) call unchanged so analytics reflect the real
trigger location.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (14)
src/components/TopMenuSection.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/sidebar/SidebarHelpCenterIcon.vuesrc/components/topbar/CurrentUserButton.vuesrc/components/topbar/LoginButton.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/composables/useHelpCenter.tssrc/locales/en/main.jsonsrc/locales/en/settings.jsonsrc/platform/settings/constants/coreSettings.tssrc/schemas/apiSchema.tssrc/stores/helpCenterStore.ts
🧰 Additional context used
📓 Path-based instructions (18)
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/locales/en/main.jsonsrc/locales/en/settings.jsonsrc/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3.5+ with TypeScript in.vuefiles, exclusively using Composition API with<script setup lang="ts">syntax
Use Tailwind 4 for styling in Vue components; avoid<style>blocks
Name Vue components using PascalCase (e.g.,MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
Prefercomputed()overrefwithwatchwhen deriving values
PreferuseModelover separately defining prop and emit for two-way binding
Usevue-i18nin composition API for string literals; place new translation entries insrc/locales/en/main.json
Usecn()utility function from@/utils/tailwindUtilfor merging Tailwind class names; do not use:class="[]"syntax
Do not use thedark:Tailwind variant; use semantic values from thestyle.csstheme instead (e.g.,bg-node-component-surface)
Do not use!importantor the!important prefix for Tailwind classes; find and correct interfering!importantclasses instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Minimize the surface area (exported values) of each module and composable
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/useHelpCenter.ts
**/**/use[A-Z]*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables using the pattern
useXyz.ts
Files:
src/composables/useHelpCenter.ts
src/**/stores/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/stores/**/*.{ts,tsx}: Maintain clear public interfaces and restrict extension access in stores
Use TypeScript for type safety in state management stores
Files:
src/stores/helpCenterStore.ts
**/*Store.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name Pinia stores using the pattern
*Store.ts
Files:
src/stores/helpCenterStore.ts
🧠 Learnings (44)
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/en/settings.json
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/schemas/apiSchema.tssrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/stores/helpCenterStore.tssrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/TopMenuSection.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/composables/useHelpCenter.tssrc/stores/helpCenterStore.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/TopMenuHelpButton.vuesrc/components/TopMenuSection.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/composables/useHelpCenter.tssrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Leverage VueUse functions for performance-enhancing styles in Vue components
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use Teleport/Suspense when needed for component rendering
Applied to files:
src/components/helpcenter/HelpCenterPopups.vuesrc/components/sidebar/SideToolbar.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use Vue 3.5+ with TypeScript in `.vue` files, exclusively using Composition API with `<script setup lang="ts">` syntax
Applied to files:
src/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not use `withDefaults` or runtime props declaration
Applied to files:
src/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Implement proper props and emits definitions in Vue components
Applied to files:
src/components/helpcenter/HelpCenterPopups.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/**/use[A-Z]*.ts : Name composables using the pattern `useXyz.ts`
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/components/sidebar/SideToolbar.vuesrc/components/topbar/LoginButton.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/components/sidebar/SideToolbar.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Applied to files:
src/components/sidebar/SideToolbar.vuesrc/components/topbar/LoginButton.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Name Vue components using PascalCase (e.g., `MenuHamburger.vue`)
Applied to files:
src/components/topbar/TopMenuHelpButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/components/topbar/TopMenuHelpButton.vuesrc/components/topbar/LoginButton.vuesrc/components/sidebar/SidebarHelpCenterIcon.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use `cn()` utility function from `@/utils/tailwindUtil` for merging Tailwind class names; do not use `:class="[]"` syntax
Applied to files:
src/components/topbar/LoginButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/components/topbar/LoginButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker
Applied to files:
src/components/topbar/LoginButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/components/topbar/LoginButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/components/topbar/LoginButton.vue
📚 Learning: 2025-12-30T22:22:38.162Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:38.162Z
Learning: In Pinia setup stores, when accessing reactive properties directly via `useStore().property` pattern (e.g., `useQueueUIStore().isOverlayExpanded`), Pinia automatically unwraps refs and returns the primitive value. The `.value` accessor is only needed when destructuring store properties or using `storeToRefs()`.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/stores/**/*.{ts,tsx} : Maintain clear public interfaces and restrict extension access in stores
Applied to files:
src/stores/helpCenterStore.ts
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.{ts,tsx} : Minimize the surface area (exported values) of each module and composable
Applied to files:
src/components/sidebar/SidebarHelpCenterIcon.vue
🧬 Code graph analysis (2)
src/composables/useHelpCenter.ts (5)
src/stores/helpCenterStore.ts (2)
HelpCenterTriggerLocation(4-4)useHelpCenterStore(6-33)src/workbench/extensions/manager/composables/useConflictDetection.ts (1)
useConflictDetection(45-709)src/services/dialogService.ts (1)
useDialogService(47-566)src/workbench/extensions/manager/composables/useConflictAcknowledgment.ts (1)
useConflictAcknowledgment(44-101)src/platform/telemetry/index.ts (1)
useTelemetry(32-42)
src/stores/helpCenterStore.ts (1)
src/scripts/domWidget.ts (1)
isVisible(155-157)
🔇 Additional comments (18)
src/locales/en/main.json (1)
830-830: LGTM: New locale entry follows conventions.The addition of the
menu.helpAndFeedbackkey follows the existing pattern and provides clear user-facing text for the Help & Feedback button.Based on learnings, only the English locale file needs to be updated manually; other language files are auto-generated on release.
src/locales/en/settings.json (1)
372-379: LGTM: Settings locale entry is well-structured.The new
Comfy_UI_TabBarLayoutentry follows the existing pattern for combo settings and provides clear descriptions for both the setting name and tooltip.src/components/sidebar/SideToolbar.vue (2)
43-43: LGTM: Conditional rendering correctly implements integrated tab bar logic.The help center icon is appropriately hidden when the integrated tab bar layout is active.
49-49: LGTM: HelpCenterPopups integration follows Vue best practices.The new HelpCenterPopups component is correctly imported and placed at the root of the side toolbar, with proper reactive state management through the computed
isIntegratedTabBarproperty.Also applies to: 58-58, 94-96
src/platform/settings/constants/coreSettings.ts (1)
551-560: LGTM: Setting definition follows the established pattern.The new
Comfy.UI.TabBarLayoutsetting is well-structured with appropriate category, type, options, and tooltip. The placement afterComfy.DevModeand beforeComfy.UseNewMenuis logical.Optional: Consider adding a
versionAddedfield (e.g.,versionAdded: '1.X.X') for consistency with other recent settings, as this helps track when features were introduced.src/components/topbar/TopMenuHelpButton.vue (2)
1-14: LGTM with suggestion: Template structure is well-implemented.The button uses the common
Buttoncomponent, includes i18n for user-facing text, and properly implements the red dot notification indicator. The visible text provides an accessible name, so noaria-labelis needed.Suggestion: Verify if the hardcoded red color
bg-[#ff3b30]on line 11 should use a semantic color token fromstyle.cssinstead. Notification/alert colors are often defined in the design system for consistency across the application.As per coding guidelines, prefer semantic values from the theme over hardcoded colors.
16-21: LGTM: Composable integration follows Vue 3 best practices.The component correctly uses the Composition API with
<script setup lang="ts">and cleanly destructures only the needed properties fromuseHelpCenter('topbar').src/components/topbar/LoginButton.vue (2)
4-16: LGTM: Visual updates align with integrated tab bar design.The variant change to "textonly" and the styled icon wrapper enhance the visual presentation while maintaining all existing functionality.
38-49: LGTM: Prop definition follows Vue 3.5 best practices.The class prop is properly typed and destructured, and the cn() utility is correctly used for class composition.
src/components/TopMenuSection.vue (2)
57-61: LGTM: Conditional rendering correctly implements integrated tab bar layout.The logic properly hides CurrentUserButton and LoginButton when integrated mode is active, aligning with the feature's goal to move these controls into the tab bar area.
97-123: LGTM: Settings store integration follows Pinia best practices.The settingStore is correctly initialized and accessed. The isIntegratedTabBar computed properly reads from the new Comfy.UI.TabBarLayout setting.
src/components/topbar/CurrentUserButton.vue (1)
16-46: LGTM: Optional showArrow prop enables flexible layout control.The prop is properly typed with a sensible default that maintains backward compatibility. This allows the integrated tab bar to hide the chevron while preserving it in the default layout.
src/components/topbar/WorkflowTabs.vue (2)
96-136: LGTM: Store integration and computed logic consistent with TopMenuSection.The settingStore initialization and isIntegratedTabBar computed follow the same pattern established in TopMenuSection, ensuring consistent behavior across the application.
70-81: TopMenuHelpButton component verified.The TopMenuHelpButton component exists and is properly implemented at
src/components/topbar/TopMenuHelpButton.vue. It follows Vue 3 Composition API guidelines with<script setup lang="ts">, uses vue-i18n for translations, and relies on Tailwind CSS for styling. The integrated tab bar UI block is well-structured with appropriate conditional rendering and spacing.src/schemas/apiSchema.ts (1)
390-390: No action required. The schema definition is correct and the default value is properly configured in coreSettings.ts withdefaultValue: 'Default', which matches one of the enum values.src/stores/helpCenterStore.ts (1)
1-33: LGTM!The store implementation is clean and follows Pinia patterns correctly. The
togglefunction appropriately only updatestriggerLocationwhen opening (not closing), whileshowalways sets the location before displaying. The type-safe union type provides good constraints.src/components/sidebar/SidebarHelpCenterIcon.vue (1)
2-10: LGTM!The component logic is cleanly delegated to the
useHelpCentercomposable, following the separation of concerns principle. The template bindings are correct.src/components/helpcenter/HelpCenterPopups.vue (1)
60-62: Verify reactivity of destructured prop in composable call.The
isSmallprop is destructured fromdefinePropsand used directly in the template, which is correct for Vue 3.5+. However, ifuseHelpCenter()needed to react toisSmallchanges, it would require passing a ref. CurrentlyuseHelpCenter()doesn't useisSmall, so this is fine.
| <Teleport to="body"> | ||
| <div | ||
| v-if="isHelpCenterVisible" | ||
| class="help-center-backdrop" | ||
| @click="closeHelpCenter" | ||
| /> | ||
| </Teleport> |
There was a problem hiding this comment.
Backdrop should use position: fixed instead of absolute.
The backdrop is teleported to body but uses position: absolute. If the body has any positioned ancestors or if the page is scrollable, the backdrop may not cover the entire viewport correctly. Using position: fixed ensures consistent full-viewport coverage.
🔎 Proposed fix
.help-center-backdrop {
- position: absolute;
+ position: fixed;
top: 0;
left: 0;
right: 0;
bottom: 0;
z-index: 9999;
background: transparent;
}Also applies to: 74-82
🤖 Prompt for AI Agents
In @src/components/helpcenter/HelpCenterPopups.vue around lines 44 - 50, The
backdrop element rendered inside Teleport uses position: absolute which can fail
to cover the viewport; update the styling for the backdrop (the div with class
"help-center-backdrop" rendered when isHelpCenterVisible and the similar
backdrop used around lines 74-82) to use position: fixed instead of absolute so
it always spans the full viewport regardless of document flow or scrolling;
locate the CSS rules for .help-center-backdrop (and any duplicate backdrop
class/inline style in the same component) and change position to fixed, keeping
existing sizing (top/left/right/bottom or width/height) and z-index intact.
| <style scoped> | ||
| .help-center-backdrop { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| z-index: 9999; | ||
| background: transparent; | ||
| } | ||
| .help-center-popup { | ||
| position: absolute; | ||
| bottom: 1rem; | ||
| z-index: 10000; | ||
| animation: slideInUp 0.2s ease-out; | ||
| pointer-events: auto; | ||
| } | ||
| .help-center-popup.sidebar-left { | ||
| left: 1rem; | ||
| } | ||
| .help-center-popup.sidebar-left.small-sidebar { | ||
| left: 1rem; | ||
| } | ||
| .help-center-popup.sidebar-right { | ||
| right: 1rem; | ||
| } | ||
| .help-center-popup.topbar-right { | ||
| top: 2rem; | ||
| right: 1rem; | ||
| bottom: auto; | ||
| animation: slideInDown 0.2s ease-out; | ||
| } | ||
| @keyframes slideInDown { | ||
| from { | ||
| opacity: 0; | ||
| transform: translateY(-20px); | ||
| } | ||
| to { | ||
| opacity: 1; | ||
| transform: translateY(0); | ||
| } | ||
| } | ||
| @keyframes slideInUp { | ||
| from { | ||
| opacity: 0; | ||
| transform: translateY(20px); | ||
| } | ||
| to { | ||
| opacity: 1; | ||
| transform: translateY(0); | ||
| } | ||
| } | ||
| </style> |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider migrating custom CSS to Tailwind utilities.
Per coding guidelines, Vue components should "Use Tailwind CSS only for styling (no custom CSS)" and "Use the correct tokens from style.css in the design system package."
The current implementation uses:
- Hardcoded z-index values (9999, 10000)
- Custom keyframe animations
- Multiple positioning classes
While animations may require CSS, the positioning and z-index could leverage Tailwind utilities or design system tokens. If Tailwind's animation utilities don't suffice, consider extracting the keyframes to a shared CSS file or using @apply in a design system context.
🤖 Prompt for AI Agents
In @src/components/helpcenter/HelpCenterPopups.vue around lines 73 - 134,
Replace hardcoded CSS in HelpCenterPopups.vue by switching positioning and
z-index to Tailwind/design tokens and moving animations to shared CSS: update
usages of .help-center-backdrop and .help-center-popup (including variants
.sidebar-left, .sidebar-right, .topbar-right, .small-sidebar) to use Tailwind
utility classes for absolute positioning, spacing and z-index tokens instead of
9999/10000; if Tailwind's built-in animations cover the behavior, replace the
local @keyframes slideInUp and slideInDown with Tailwind animation classes,
otherwise move these keyframes into the shared design-system CSS (or an
@apply-enabled file) and reference them via a named utility or class so the
component contains only utility classes.
| // Initialize release store on mount | ||
| onMounted(async () => { | ||
| // Initialize release store to fetch releases for toast and popup | ||
| await releaseStore.initialize() | ||
| }) |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Add error handling for release store initialization.
The releaseStore.initialize() call is not wrapped in a try/catch. If the initialization fails (e.g., network error), the error will be unhandled and may cause issues in development or crash reporting.
🔎 Proposed fix
// Initialize release store on mount
onMounted(async () => {
- // Initialize release store to fetch releases for toast and popup
- await releaseStore.initialize()
+ try {
+ // Initialize release store to fetch releases for toast and popup
+ await releaseStore.initialize()
+ } catch (error) {
+ console.error('[HelpCenter] Failed to initialize release store:', error)
+ }
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Initialize release store on mount | |
| onMounted(async () => { | |
| // Initialize release store to fetch releases for toast and popup | |
| await releaseStore.initialize() | |
| }) | |
| // Initialize release store on mount | |
| onMounted(async () => { | |
| try { | |
| // Initialize release store to fetch releases for toast and popup | |
| await releaseStore.initialize() | |
| } catch (error) { | |
| console.error('[HelpCenter] Failed to initialize release store:', error) | |
| } | |
| }) |
🤖 Prompt for AI Agents
In @src/composables/useHelpCenter.ts around lines 85 - 89, Wrap the onMounted
initialization of the release store in a try/catch: call
releaseStore.initialize() inside try, handle failures in catch by logging the
error (e.g., console.error or your app logger), optionally surface a
user-friendly fallback (e.g., display a toast or set a local error state) and
avoid rethrowing so the unhandled error doesn’t crash the app; update the
onMounted block that calls releaseStore.initialize() accordingly and include
references to the onMounted callback and releaseStore.initialize() so reviewers
can find the change.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @src/composables/useHelpCenter.ts:
- Around line 86-89: The onMounted handler calls releaseStore.initialize()
without error handling; wrap the await releaseStore.initialize() call in a
try/catch inside the onMounted callback (or add a .catch) to handle
initialization failures, log the error via the app logger or console, and ensure
a safe fallback state (e.g., leave releases empty or set a flag on releaseStore)
so the help center still mounts even if releases fail to load; update the
onMounted block that references releaseStore.initialize() accordingly.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/composables/useHelpCenter.ts
🧰 Additional context used
📓 Path-based instructions (11)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/composables/useHelpCenter.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/composables/useHelpCenter.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/useHelpCenter.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/composables/useHelpCenter.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/composables/useHelpCenter.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/composables/useHelpCenter.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/composables/useHelpCenter.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/composables/useHelpCenter.ts
**/**/use[A-Z]*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables using the pattern
useXyz.ts
Files:
src/composables/useHelpCenter.ts
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/composables/useHelpCenter.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Minimize the surface area (exported values) of each module and composable
Files:
src/composables/useHelpCenter.ts
🧠 Learnings (8)
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Implement proper error handling in stores
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.{ts,tsx,vue} : Implement proper error handling in code
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Implement proper error handling
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/composables/useHelpCenter.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/composables/useHelpCenter.ts
🧬 Code graph analysis (1)
src/composables/useHelpCenter.ts (5)
src/stores/helpCenterStore.ts (2)
HelpCenterTriggerLocation(4-4)useHelpCenterStore(6-33)src/platform/settings/settingStore.ts (1)
useSettingStore(46-252)src/workbench/extensions/manager/composables/useConflictDetection.ts (1)
useConflictDetection(45-709)src/workbench/extensions/manager/composables/useConflictAcknowledgment.ts (1)
useConflictAcknowledgment(44-101)src/platform/telemetry/index.ts (1)
useTelemetry(32-42)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: playwright-tests-chromium-sharded (8, 8)
- GitHub Check: playwright-tests-chromium-sharded (2, 8)
- GitHub Check: playwright-tests-chromium-sharded (7, 8)
- GitHub Check: playwright-tests-chromium-sharded (1, 8)
- GitHub Check: playwright-tests-chromium-sharded (5, 8)
- GitHub Check: playwright-tests-chromium-sharded (4, 8)
- GitHub Check: playwright-tests-chromium-sharded (3, 8)
- GitHub Check: playwright-tests-chromium-sharded (6, 8)
- GitHub Check: playwright-tests (chromium-2x)
- GitHub Check: playwright-tests (chromium-0.5x)
- GitHub Check: playwright-tests (mobile-chrome)
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: collect
🔇 Additional comments (1)
src/composables/useHelpCenter.ts (1)
43-48: Telemetry tracking correctly reflects trigger location.The implementation properly uses the
triggerFromparameter to generate an accuratebutton_idfor analytics, ensuring telemetry data distinguishes between topbar and sidebar triggers.
| onMounted(async () => { | ||
| // Initialize release store to fetch releases for toast and popup | ||
| await releaseStore.initialize() | ||
| }) |
There was a problem hiding this comment.
Add error handling for release store initialization.
The releaseStore.initialize() call lacks a try-catch wrapper. If initialization fails (e.g., network error), the unhandled promise rejection could leave the help center without release data and prevent users from seeing update notifications.
🔎 Proposed fix
// Initialize release store on mount
onMounted(async () => {
- // Initialize release store to fetch releases for toast and popup
- await releaseStore.initialize()
+ try {
+ // Initialize release store to fetch releases for toast and popup
+ await releaseStore.initialize()
+ } catch (error) {
+ console.error('[HelpCenter] Failed to initialize release store:', error)
+ }
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| onMounted(async () => { | |
| // Initialize release store to fetch releases for toast and popup | |
| await releaseStore.initialize() | |
| }) | |
| onMounted(async () => { | |
| try { | |
| // Initialize release store to fetch releases for toast and popup | |
| await releaseStore.initialize() | |
| } catch (error) { | |
| console.error('[HelpCenter] Failed to initialize release store:', error) | |
| } | |
| }) |
🤖 Prompt for AI Agents
In @src/composables/useHelpCenter.ts around lines 86 - 89, The onMounted handler
calls releaseStore.initialize() without error handling; wrap the await
releaseStore.initialize() call in a try/catch inside the onMounted callback (or
add a .catch) to handle initialization failures, log the error via the app
logger or console, and ensure a safe fallback state (e.g., leave releases empty
or set a flag on releaseStore) so the help center still mounts even if releases
fail to load; update the onMounted block that references
releaseStore.initialize() accordingly.
|
Thanks for putting this behind a settings option! As for the PR, the user account button is a bit cramped on my side vs what I see in your screenshot. Is this just an issue on my end? Using Chrome |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @src/components/topbar/CurrentUserButton.vue:
- Around line 12-21: The component is forwarding caller classes to the root div
instead of the clickable <Button>, so sizing from parents (e.g., WorkflowTabs)
is ineffective; update the template to bind $attrs (especially class) onto the
internal <Button> element rather than the outer wrapper and use explicit
class/prop merging for the compact prop (e.g., keep using cn(...) for internal
classes but merge $attrs.class there), ensure the outer root remains a wrapper
without swallowing caller attributes, and propagate remaining $attrs to the
<Button> so sizing and other attributes apply correctly (apply same change for
the other similar block around lines 46-53).
In @src/components/topbar/WorkflowTabs.vue:
- Around line 128-137: Extract the repeated setting key 'Comfy.UI.TabBarLayout'
and the comparison value 'Integrated' into exported named constants (e.g.,
TAB_BAR_LAYOUT_KEY and TAB_BAR_LAYOUT_INTEGRATED) and replace the raw strings in
WorkflowTabs.vue (where settingStore and computed isIntegratedTabBar are
defined), TopMenuSection.vue, and SideToolbar.vue with those constants; add the
constants to a shared module (or export them from coreSettings.ts/apiSchema.ts
if appropriate) and update imports so isIntegratedTabBar uses the new
TAB_BAR_LAYOUT_KEY constant for settingStore.get(...) and compares against
TAB_BAR_LAYOUT_INTEGRATED.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/components/topbar/CurrentUserButton.vuesrc/components/topbar/WorkflowTabs.vue
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only; never use Options API
Use<script setup lang="ts">syntax for component logic
Use Tailwind 4 utility classes for styling; avoid<style>blocks in Vue components
Do not use thedark:Tailwind variant; use semantic values fromstyle.csstheme instead (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging class names; never use:class="[]"syntax
Never use!importantor the!prefix for Tailwind classes; find and fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentages (e.g.,w-4/5instead ofw-[80%],w-1/2instead ofw-[50%])
Use Vue 3.5 TypeScript style default prop declaration with destructuring; avoidwithDefaultsand runtime props
UsedefineModelfor v-model bindings instead of separately defining props and emits
Prefer reactive props destructuring overconst props = defineProps<...>
Define slots via template usage, notdefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Usereffor reactive state,computed()for computed properties, andwatch/watchEffectfor side effects
Avoid usingrefandwatcht...
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLeverage VueUse functions for performance-enhancing utilities
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements; do not mix inlinetypeimports in the same statement
Sort and group imports by plugin; runpnpm formatbefore committing
Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Code should be well-designed with clear names for everything; write code that is expressive and self-documenting
Avoid redundant comments and clean up code as you go; comments should explain why, not what
Ask if there is a simpler way to implement functionality; refactor complex code to simplify it
Minimize nesting depth (e.g.,if () { ... }orfor () { ... }); watch for arrow anti-pattern
Watch out for code smells and refactor to avoid them
Never useanytype; use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Indent with 2 spaces; use single quotes; no trailing semicolons; max line width 80 (per .prettierrc)
Complex type definitions used in multiple related places should be extracted and named for reuse
Implement proper error handling
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g., MenuHamburger.vue)
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
🧠 Learnings (22)
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2026-01-09T00:50:57.103Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing utilities
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/topbar/WorkflowTabs.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/topbar/WorkflowTabs.vuesrc/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Define proper props and emits definitions in Vue components
Applied to files:
src/components/topbar/CurrentUserButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/topbar/CurrentUserButton.vue
📚 Learning: 2026-01-09T00:50:57.103Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Use `cn()` utility from `@/utils/tailwindUtil` for merging class names; never use `:class="[]"` syntax
Applied to files:
src/components/topbar/CurrentUserButton.vue
🔇 Additional comments (1)
src/components/topbar/WorkflowTabs.vue (1)
70-82: Critical: CurrentUserButton doesn't accept class prop; web users cannot log in in integrated mode.
Line 75-79 (CurrentUserButton): CurrentUserButton's
defineProps(line 50-53 of the component) only acceptsshowArrowandcompact—it does not define aclassprop. Passingclass="shrink-0 p-1"will be ignored by Vue, so theshrink-0class won't apply to the button element. Addclass?: stringto the props definition and forward it to the internal Button component to fix the "cramped" styling.Line 81 (LoginButton visibility): LoginButton is shown only when
isDesktop(Electron). In integrated mode on web/non-Electron browsers, logged-out users have no visible way to log in—there's no LoginButton in WorkflowTabs.vue or TopMenuSection.vue (which also requires!isIntegratedTabBar). The only alternative is a settings dialog, which is not a discoverable entry point. Either show LoginButton for web users in integrated mode, or provide an alternative login UI.⛔ Skipped due to learnings
Learnt from: DrJKL Repo: Comfy-Org/ComfyUI_frontend PR: 7649 File: src/platform/cloud/subscription/components/PricingTable.vue:185-201 Timestamp: 2025-12-22T21:36:16.031Z Learning: In the Comfy-Org/ComfyUI_frontend repository, avoid creating single-use variants for the Button component (and other UI components). Variants should be reusable across multiple use cases. It's acceptable to use a mix of variant props and manual Tailwind classes temporarily when a specific styling need exists in only one place, with consolidation deferred to a later phase when patterns emerge.Learnt from: DrJKL Repo: Comfy-Org/ComfyUI_frontend PR: 7559 File: .storybook/preview.ts:61-61 Timestamp: 2025-12-16T17:30:29.719Z Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.Learnt from: christian-byrne Repo: Comfy-Org/ComfyUI_frontend PR: 6300 File: src/platform/updates/components/WhatsNewPopup.vue:5-13 Timestamp: 2025-12-09T03:50:03.127Z Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.Learnt from: DrJKL Repo: Comfy-Org/ComfyUI_frontend PR: 7598 File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131 Timestamp: 2025-12-18T02:07:44.374Z Learning: Comfy-Org/ComfyUI_frontend uses Tailwind CSS v4 utilities, including the new “safe” overflow-alignment classes. Do not flag items-center-safe, justify-*-safe, or place-*-safe utilities as invalid in src/**/*.vue or stories.
| :class=" | ||
| cn( | ||
| 'flex items-center gap-1 rounded-full hover:bg-interface-button-hover-surface justify-center', | ||
| compact && 'size-full ' | ||
| ) | ||
| " | ||
| > | ||
| <UserAvatar :photo-url="photoURL" /> | ||
| <UserAvatar :photo-url="photoURL" :class="compact && 'size-full'" /> | ||
|
|
||
| <i class="icon-[lucide--chevron-down] size-3 px-1" /> | ||
| <i v-if="showArrow" class="icon-[lucide--chevron-down] size-3 px-1" /> |
There was a problem hiding this comment.
Forward $attrs (especially class) to the internal <Button> to make sizing controllable; likely fixes the “cramped” report.
Right now, a caller’s class="..." lands on the outer <div> (component root), not the clickable <Button>, so WorkflowTabs’ sizing classes won’t do what they look like they’re doing.
Proposed fix
<script setup lang="ts">
import Popover from 'primevue/popover'
-import { computed, ref } from 'vue'
+import { computed, ref, useAttrs } from 'vue'
import UserAvatar from '@/components/common/UserAvatar.vue'
import Button from '@/components/ui/button/Button.vue'
import { useCurrentUser } from '@/composables/auth/useCurrentUser'
import { cn } from '@/utils/tailwindUtil'
import CurrentUserPopover from './CurrentUserPopover.vue'
+defineOptions({ inheritAttrs: false })
+
const { showArrow = true, compact = false } = defineProps<{
showArrow?: boolean
compact?: boolean
}>()
+const attrs = useAttrs()
+
const { isLoggedIn, userPhotoUrl } = useCurrentUser() <template>
<div>
<Button
v-if="isLoggedIn"
- class="p-1 hover:bg-transparent"
+ v-bind="attrs"
+ class="p-1 hover:bg-transparent"
variant="muted-textonly"
:aria-label="$t('g.currentUser')"
@click="popover?.toggle($event)"
>
<div
:class="
cn(
'flex items-center gap-1 rounded-full hover:bg-interface-button-hover-surface justify-center',
- compact && 'size-full '
+ compact && 'size-full'
)
"
>
<UserAvatar :photo-url="photoURL" :class="compact && 'size-full'" />
<i v-if="showArrow" class="icon-[lucide--chevron-down] size-3 px-1" />
</div>
</Button>Also applies to: 46-53
🤖 Prompt for AI Agents
In @src/components/topbar/CurrentUserButton.vue around lines 12 - 21, The
component is forwarding caller classes to the root div instead of the clickable
<Button>, so sizing from parents (e.g., WorkflowTabs) is ineffective; update the
template to bind $attrs (especially class) onto the internal <Button> element
rather than the outer wrapper and use explicit class/prop merging for the
compact prop (e.g., keep using cn(...) for internal classes but merge
$attrs.class there), ensure the outer root remains a wrapper without swallowing
caller attributes, and propagate remaining $attrs to the <Button> so sizing and
other attributes apply correctly (apply same change for the other similar block
around lines 46-53).
| const settingStore = useSettingStore() | ||
| const workspaceStore = useWorkspaceStore() | ||
| const workflowStore = useWorkflowStore() | ||
| const workflowBookmarkStore = useWorkflowBookmarkStore() | ||
| const workflowService = useWorkflowService() | ||
| const { isLoggedIn } = useCurrentUser() | ||
| const isIntegratedTabBar = computed( | ||
| () => settingStore.get('Comfy.UI.TabBarLayout') === 'Integrated' | ||
| ) |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🏁 Script executed:
# Find the setting store file
fd -type f -name '*settingStore*' src/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 196
🏁 Script executed:
# Search for useSettingStore export
rg -n 'export.*useSettingStore|function useSettingStore' src/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 172
🏁 Script executed:
# Get context around WorkflowTabs.vue to see full implementation
wc -l src/components/topbar/WorkflowTabs.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 112
🏁 Script executed:
# Read the settingStore.ts file to understand the get() method
head -n 250 src/platform/settings/settingStore.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 7858
🏁 Script executed:
# Get context around lines 128-137 in WorkflowTabs.vue
sed -n '120,150p' src/components/topbar/WorkflowTabs.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 926
🏁 Script executed:
# Check if the string 'Comfy.UI.TabBarLayout' is used elsewhere in the codebase
rg -n "Comfy\.UI\.TabBarLayout" src/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 569
🏁 Script executed:
# Check if 'Integrated' tab bar layout value is used elsewhere
rg -n "===\s*['\"]Integrated['\"]|['\"]Integrated['\"]" src/components/topbar/WorkflowTabs.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 140
🏁 Script executed:
# Look for any constants file or types that might already define these values
fd -type f -name '*constant*' -o -name '*type*' src/platform/settings/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 240
🏁 Script executed:
# Check the apiSchema and coreSettings files for how these values are defined
sed -n '385,395p' src/schemas/apiSchema.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 600
🏁 Script executed:
# Check coreSettings definition
sed -n '545,565p' src/platform/settings/constants/coreSettings.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 691
🏁 Script executed:
# Verify that computed() tracks reactive dependencies properly by checking if there are any similar patterns in the codebase
rg -n "computed\s*\(\s*\(\)\s*=>\s*\w+Store\.get\(" src/components/ | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 549
🏁 Script executed:
# Check if constants are exported anywhere for these setting keys
rg -n "export.*Comfy\.UI\.TabBarLayout|export.*INTEGRATED|export.*TAB_BAR" src/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
Consider extracting the tab layout setting key and value as constants.
The setting key 'Comfy.UI.TabBarLayout' and comparison value 'Integrated' are duplicated across WorkflowTabs.vue, TopMenuSection.vue, and SideToolbar.vue. While these values are already constrained by the zod schema in apiSchema.ts and defined in coreSettings.ts, exporting them as named constants would reduce string drift and centralize future changes.
🤖 Prompt for AI Agents
In @src/components/topbar/WorkflowTabs.vue around lines 128 - 137, Extract the
repeated setting key 'Comfy.UI.TabBarLayout' and the comparison value
'Integrated' into exported named constants (e.g., TAB_BAR_LAYOUT_KEY and
TAB_BAR_LAYOUT_INTEGRATED) and replace the raw strings in WorkflowTabs.vue
(where settingStore and computed isIntegratedTabBar are defined),
TopMenuSection.vue, and SideToolbar.vue with those constants; add the constants
to a shared module (or export them from coreSettings.ts/apiSchema.ts if
appropriate) and update imports so isIntegratedTabBar uses the new
TAB_BAR_LAYOUT_KEY constant for settingStore.get(...) and compares against
TAB_BAR_LAYOUT_INTEGRATED.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @src/platform/settings/constants/coreSettings.ts:
- Around line 551-560: Add a versionAdded property to the setting object with id
'Comfy.UI.TabBarLayout' to match other settings; e.g., add versionAdded: '1.6.0'
(or the actual release version when this setting was introduced) alongside
id/name/type/defaultValue so the entry follows the established pattern for
tracking when settings were added.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
src/components/TopMenuSection.vuesrc/locales/en/main.jsonsrc/platform/settings/constants/coreSettings.tssrc/schemas/apiSchema.ts
🧰 Additional context used
📓 Path-based instructions (11)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLeverage VueUse functions for performance-enhancing utilities
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/components/TopMenuSection.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Minimize the surface area (exported values) of each module and composable
Use es-toolkit for utility functions
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements; do not mix inlinetypeimports in the same statement
Sort and group imports by plugin; runpnpm formatbefore committing
Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Code should be well-designed with clear names for everything; write code that is expressive and self-documenting
Avoid redundant comments and clean up code as you go; comments should explain why, not what
Ask if there is a simpler way to implement functionality; refactor complex code to simplify it
Minimize nesting depth (e.g.,if () { ... }orfor () { ... }); watch for arrow anti-pattern
Watch out for code smells and refactor to avoid them
Never useanytype; use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Indent with 2 spaces; use single quotes; no trailing semicolons; max line width 80 (per .prettierrc)
Complex type definitions used in multiple related places should be extracted and named for reuse
Implement proper error handling
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/components/TopMenuSection.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/components/TopMenuSection.vue
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional; use function declarations instead of function expressions when possible
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only; never use Options API
Use<script setup lang="ts">syntax for component logic
Use Tailwind 4 utility classes for styling; avoid<style>blocks in Vue components
Do not use thedark:Tailwind variant; use semantic values fromstyle.csstheme instead (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging class names; never use:class="[]"syntax
Never use!importantor the!prefix for Tailwind classes; find and fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentages (e.g.,w-4/5instead ofw-[80%],w-1/2instead ofw-[50%])
Use Vue 3.5 TypeScript style default prop declaration with destructuring; avoidwithDefaultsand runtime props
UsedefineModelfor v-model bindings instead of separately defining props and emits
Prefer reactive props destructuring overconst props = defineProps<...>
Define slots via template usage, notdefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Usereffor reactive state,computed()for computed properties, andwatch/watchEffectfor side effects
Avoid usingrefandwatcht...
Files:
src/components/TopMenuSection.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/TopMenuSection.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/TopMenuSection.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g., MenuHamburger.vue)
Files:
src/components/TopMenuSection.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/TopMenuSection.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/TopMenuSection.vue
🧠 Learnings (15)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/schemas/apiSchema.tssrc/platform/settings/constants/coreSettings.tssrc/components/TopMenuSection.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/TopMenuSection.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/TopMenuSection.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (5)
src/schemas/apiSchema.ts (1)
402-402: LGTM! Schema addition is correct and consistent.The new setting is properly defined with the enum values matching the core setting definition. The Zod v3-compatible syntax is used correctly.
src/locales/en/main.json (1)
840-840: LGTM! Localization key is properly structured.The new "helpAndFeedback" translation follows the established pattern for menu items and provides clear, user-facing text.
src/components/TopMenuSection.vue (3)
102-102: LGTM! Setting store import follows best practices.The import of
useSettingStoreis correctly placed and follows the repository's import organization pattern.
114-114: LGTM! Setting store integration is clean and reactive.The computed property
isIntegratedTabBaris efficiently implemented and will reactively update when the setting changes. The comparison logic is straightforward and correct.Also applies to: 132-134
62-66: LGTM! Conditional rendering logic is correct and preserves existing behavior.The updated conditions properly hide the CurrentUserButton and LoginButton when integrated tab bar mode is enabled, while preserving the existing authentication and platform checks. The use of
&&for combining conditions is clear and follows Vue best practices.
| { | ||
| id: 'Comfy.UI.TabBarLayout', | ||
| category: ['Appearance', 'General'], | ||
| name: 'Tab Bar Layout', | ||
| type: 'combo', | ||
| options: ['Default', 'Integrated'], | ||
| tooltip: | ||
| 'Controls the layout of the tab bar. "Integrated" moves Help and User controls into the tab bar area.', | ||
| defaultValue: 'Default' | ||
| }, |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider adding a versionAdded field for tracking.
The setting definition is well-structured and follows the established pattern. However, most recent settings include a versionAdded field to track when the setting was introduced.
📝 Suggested enhancement
{
id: 'Comfy.UI.TabBarLayout',
category: ['Appearance', 'General'],
name: 'Tab Bar Layout',
type: 'combo',
options: ['Default', 'Integrated'],
tooltip:
'Controls the layout of the tab bar. "Integrated" moves Help and User controls into the tab bar area.',
- defaultValue: 'Default'
+ defaultValue: 'Default',
+ versionAdded: '1.x.x' // Replace with actual version
}🤖 Prompt for AI Agents
In @src/platform/settings/constants/coreSettings.ts around lines 551 - 560, Add
a versionAdded property to the setting object with id 'Comfy.UI.TabBarLayout' to
match other settings; e.g., add versionAdded: '1.6.0' (or the actual release
version when this setting was introduced) alongside id/name/type/defaultValue so
the entry follows the established pattern for tracking when settings were added.
Summary
The current help / feedback is often overlooked by users, this adds a setting that makes it more visible moving it up into the tab bar and moves the user login/profile button out of the "action bar" into the tab bar.
Changes
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito