Skip to content

feat: local/legacy settings dialog fix #7990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simula-r merged 1 commit into from
Jan 13, 2026
Merged

feat: local/legacy settings dialog fix #7990

simula-r merged 1 commit into from
Jan 13, 2026
+18 −9

Conversation

@simula-r
Copy link
Contributor

@simula-r simula-r commented Jan 13, 2026 •
edited
Loading

Summary

Fix the issue where local/desktop users would top up and then see the settings homepage dialog instead of the credits tab.

Changes

  • What: useSubscription.ts, TopUpCreditsDialogContent.vue, SubscriptionRequiredDialogContent.vue
  • Breaking:
  • Dependencies:

Screenshots (if applicable)

Showing this screen after topping up on local/desktop:
image

┆Issue is synchronized with this Notion page by Unito

@simula-r simula-r requested a review from a team as a code owner January 13, 2026 03:29
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR introduces a new isSubscriptionEnabled() utility function in the subscription composable that determines if cloud subscription mode is available. Components now use this function to conditionally control subscription-related UI flows instead of checking environment flags directly.

Changes

Cohort / File(s) Summary
Subscription capability composable
src/platform/cloud/subscription/composables/useSubscription.ts		 Added isSubscriptionEnabled() function to determine if subscription capability is enabled; exposed in composable's public API; replaces previous shouldWatchCancellation in return object.
Subscription-related UI components
src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue,
src/components/dialog/content/TopUpCreditsDialogContent.vue		 Updated to use isSubscriptionEnabled() from composable instead of runtime environment/config checks for controlling conditional UI visibility and post-purchase navigation flows.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a166ec9 and 350aec1.

📒 Files selected for processing (3)
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use <script setup lang="ts"> for component logic in Vue SFCs
Avoid <style> blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries in src/locales/en/main.json
Use Tailwind utility classes instead of dark: variant - use semantic values from style.css theme (e.g., bg-node-component-surface)
Use cn() utility from @/utils/tailwindUtil for merging Tailwind class names instead of :class="[]" or hardcoding
Never use !important or ! Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g., w-4/5 instead of w-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoid withDefaults or runtime props
Prefer defineModel over separately defining a prop and emit for v-model bindings
Define slots via template usage, not via defineSlots
Use same-name shorthand for slot prop bindings (e.g., :isExpanded instead of :is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Name Vue components in PascalCase (e.g., MenuHamburger.vue)

Files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/{services,composables}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/{services,composables}/**/*.{ts,tsx}: Use api.apiURL() for backend endpoints instead of constructing URLs directly
Use api.fileURL() for static file access instead of constructing URLs directly

Files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
🧠 Learnings (23)
📚 Learning: 2025-11-24T19:47:34.324Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{composables,components}/**/*.{ts,tsx,vue} : Clean up subscriptions in state management to prevent memory leaks

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-12-09T03:49:52.828Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2026-01-10T00:24:17.695Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Leverage VueUse functions for performance-enhancing composables

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-09T21:40:12.361Z 
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-16T22:26:49.463Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-22T21:36:08.369Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2026-01-08T02:26:18.357Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-11T12:25:15.470Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-12-18T02:07:38.870Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-18T21:15:46.862Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-21T01:06:02.786Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2026-01-12T17:39:27.738Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

  • src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContent.vue
  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-11-24T19:47:45.616Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2026-01-10T00:24:17.695Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/composables/**/*.ts : Name composables as `useXyz.ts` (e.g., `useForm.ts`)

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-11-24T19:47:45.616Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-11-24T19:47:02.860Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-11-24T19:47:02.860Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-11-24T19:47:45.616Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-18T16:03:02.066Z 
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

  • src/components/dialog/content/TopUpCreditsDialogContent.vue
📚 Learning: 2025-12-09T03:39:54.501Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-12-13T11:03:11.264Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-12-17T00:40:09.635Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
📚 Learning: 2025-12-30T22:22:33.836Z 
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

  • src/platform/cloud/subscription/composables/useSubscription.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: deploy-and-comment
  • GitHub Check: test
  • GitHub Check: setup
  • GitHub Check: collect
  • GitHub Check: lint-and-format
🔇 Additional comments (7)
src/platform/cloud/subscription/composables/useSubscription.ts (3)

124-129: LGTM! Clean utility function with good documentation.

The isSubscriptionEnabled function properly encapsulates the subscription mode check. Using Boolean() ensures a clean boolean return type.

131-138: Good refactor to use function reference for lazy evaluation.

Passing isSubscriptionEnabled as a function reference to shouldWatchCancellation allows the watcher to evaluate the condition dynamically rather than capturing a stale boolean value at initialization time.

256-258: Clean API surface extension.

The new utility is properly categorized and exported, making it available to consuming components.

src/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vue (2)

142-143: Good refactor to use centralized subscription check.

The component now uses isSubscriptionEnabled() from the composable instead of directly checking isCloud and window.__CONFIG__. This centralizes the logic and makes the codebase more maintainable.

Also applies to: 159-159

161-198: Polling logic is well-structured with proper cleanup.

The polling implementation correctly:

  • Stops existing polling before starting new
  • Limits attempts with MAX_POLL_ATTEMPTS
  • Handles errors gracefully
  • Cleans up on unmount via onBeforeUnmount

This follows the guideline to clean up subscriptions to prevent memory leaks.

src/components/dialog/content/TopUpCreditsDialogContent.vue (2)

161-161: Correct integration of subscription check for conditional navigation.

The import and destructuring of isSubscriptionEnabled from useSubscription is properly set up to support the post-purchase navigation fix.

Also applies to: 179-179

257-261: Core fix correctly implemented.

The conditional navigation now properly routes:

  • Cloud subscription users → 'subscription' panel
  • Local/desktop users → 'credits' panel

This directly addresses the PR objective of fixing the settings dialog navigation for local/desktop users after top-up.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 01/13/2026, 03:31:09 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

🎭 Playwright Tests: ❌ Failed

Results: 500 passed, 1 failed, 2 flaky, 8 skipped (Total: 511)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 490 / ❌ 1 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Bundle Size Report

Summary

  • Raw size: 19.4 MB baseline 19.4 MB — 🔴 +191 B
  • Gzip: 3.95 MB baseline 3.95 MB — 🔴 +66 B
  • Brotli: 3.02 MB baseline 3.02 MB — 🔴 +236 B
  • Bundles: 98 current • 98 baseline • 38 added / 38 removed

Category Glance
App Entry Points 🔴 +178 B (3.32 MB) · Other 🔴 +13 B (5.25 MB) · Vendor & Third-Party ⚪ 0 B (9.19 MB) · Graph Workspace ⚪ 0 B (1.04 MB) · Panels & Settings ⚪ 0 B (372 kB) · UI Components ⚪ 0 B (200 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.32 MB (baseline 3.32 MB) • 🔴 +178 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-Ddyj-Elm.js (new) — 3.12 MB 🔴 +3.12 MB 🔴 +654 kB 🔴 +497 kB
assets/index-C_pmfadn.js (removed) 3.12 MB — 🟢 -3.12 MB 🟢 -654 kB 🟢 -496 kB
assets/index-B4xL69H3.js (new) — 200 kB 🔴 +200 kB 🔴 +44 kB 🔴 +36.4 kB
assets/index-TpI5dvzF.js (removed) 200 kB — 🟢 -200 kB 🟢 -44 kB 🟢 -36.4 kB
assets/index-4SeCsy6M.js (removed) 345 B — 🟢 -345 B 🟢 -243 B 🟢 -210 B
assets/index-B2utaQza.js (new) — 345 B 🔴 +345 B 🔴 +243 B 🔴 +232 B

Status: 3 added / 3 removed

Graph Workspace — 1.04 MB (baseline 1.04 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-B6YVdPXQ.js (new) — 1.04 MB 🔴 +1.04 MB 🔴 +200 kB 🔴 +151 kB
assets/GraphView-DoybSy1a.js (removed) 1.04 MB — 🟢 -1.04 MB 🟢 -200 kB 🟢 -151 kB

Status: 1 added / 1 removed

Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-B_PbiBg2.js (new) — 6.63 kB 🔴 +6.63 kB 🔴 +2.14 kB 🔴 +1.9 kB
assets/UserSelectView-CjIoJQr6.js (removed) 6.63 kB — 🟢 -6.63 kB 🟢 -2.14 kB 🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LegacyCreditsPanel-3lBFnv6R.js (removed) 25.1 kB — 🟢 -25.1 kB 🟢 -5.74 kB 🟢 -5 kB
assets/LegacyCreditsPanel-agJZ_3TW.js (new) — 25.1 kB 🔴 +25.1 kB 🔴 +5.74 kB 🔴 +5.01 kB
assets/KeybindingPanel-BmE4p367.js (new) — 14.8 kB 🔴 +14.8 kB 🔴 +3.57 kB 🔴 +3.12 kB
assets/KeybindingPanel-DrNf_zME.js (removed) 14.8 kB — 🟢 -14.8 kB 🟢 -3.57 kB 🟢 -3.13 kB
assets/ExtensionPanel-Buv-MVGG.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -2.62 kB 🟢 -2.3 kB
assets/ExtensionPanel-F4mofbuj.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +2.62 kB 🔴 +2.3 kB
assets/AboutPanel-D6AW8ETg.js (new) — 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.2 kB
assets/AboutPanel-dLhmQSjQ.js (removed) 9.16 kB — 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/ServerConfigPanel-BVU303HM.js (new) — 7.51 kB 🔴 +7.51 kB 🔴 +2.04 kB 🔴 +1.8 kB
assets/ServerConfigPanel-Mz_z39Dj.js (removed) 7.51 kB — 🟢 -7.51 kB 🟢 -2.04 kB 🟢 -1.8 kB
assets/UserPanel-B2IHkXWw.js (removed) 6.88 kB — 🟢 -6.88 kB 🟢 -1.79 kB 🟢 -1.56 kB
assets/UserPanel-gxic-X3Z.js (new) — 6.88 kB 🔴 +6.88 kB 🔴 +1.79 kB 🔴 +1.57 kB
assets/settings-BGQfQzTx.js 25.6 kB 25.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BVE4KHTw.js 22.7 kB 22.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BVtpJmlU.js 30.9 kB 30.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C2aO00Dz.js 28.6 kB 28.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-Cm3ieBXR.js 27.8 kB 27.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CzQKMdK3.js 26.2 kB 26.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CzYUIUnL.js 27.1 kB 27.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DwKpL7jw.js 26.3 kB 26.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DX8feV4n.js 25.3 kB 25.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-mWzYycGc.js 22 kB 22 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-U4AdZ8Rl.js 34.9 kB 34.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 200 kB (baseline 200 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LazyImage.vue_vue_type_script_setup_true_lang-d2LUk-Ob.js (new) — 65.6 kB 🔴 +65.6 kB 🔴 +13.3 kB 🔴 +11.5 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-D792ZMOc.js (removed) 65.6 kB — 🟢 -65.6 kB 🟢 -13.3 kB 🟢 -11.5 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-ClpzfqS2.js (new) — 56.4 kB 🔴 +56.4 kB 🔴 +8.77 kB 🔴 +7.54 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-DoOz8Xre.js (removed) 56.4 kB — 🟢 -56.4 kB 🟢 -8.77 kB 🟢 -7.53 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DrbWo_mK.js (new) — 49 kB 🔴 +49 kB 🔴 +10.5 kB 🔴 +9.14 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-H2K2vUgy.js (removed) 49 kB — 🟢 -49 kB 🟢 -10.5 kB 🟢 -9.14 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-C0x4LaZI.js (new) — 10.9 kB 🔴 +10.9 kB 🔴 +2.89 kB 🔴 +2.56 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-C4vD0WYN.js (removed) 10.9 kB — 🟢 -10.9 kB 🟢 -2.89 kB 🟢 -2.56 kB
assets/ComfyQueueButton-Bsbs287U.js (new) — 8.83 kB 🔴 +8.83 kB 🔴 +2.58 kB 🔴 +2.29 kB
assets/ComfyQueueButton-DZysR4b7.js (removed) 8.83 kB — 🟢 -8.83 kB 🟢 -2.58 kB 🟢 -2.3 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-BpdsxXg6.js (new) — 3.72 kB 🔴 +3.72 kB 🔴 +1.45 kB 🔴 +1.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-DTmR7chl.js (removed) 3.72 kB — 🟢 -3.72 kB 🟢 -1.45 kB 🟢 -1.31 kB
assets/WidgetButton-ByqFNFej.js (removed) 2.21 kB — 🟢 -2.21 kB 🟢 -996 B 🟢 -896 B
assets/WidgetButton-CoIe6Tnt.js (new) — 2.21 kB 🔴 +2.21 kB 🔴 +995 B 🔴 +900 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-D3Uf51Ue.js (removed) 2.14 kB — 🟢 -2.14 kB 🟢 -888 B 🟢 -763 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-mo-pZmZp.js (new) — 2.14 kB 🔴 +2.14 kB 🔴 +888 B 🔴 +764 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DWEfpRJs.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-B3SJAWc3.js (removed) 7.51 kB — 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.57 kB
assets/keybindingService-DfbIgbA2.js (new) — 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.57 kB
assets/audioService-BraVis5C.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -960 B 🟢 -823 B
assets/audioService-BTB-diq0.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +827 B
assets/serverConfigStore-lZrt20fn.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-B8YIVoVM.js (removed) 1.41 kB — 🟢 -1.41 kB 🟢 -649 B 🟢 -547 B
assets/audioUtils-BMeQErxw.js (new) — 1.41 kB 🔴 +1.41 kB 🔴 +650 B 🔴 +549 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.19 MB (baseline 9.19 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-C2WamoVK.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-Da7BzmIq.js 3.9 MB 3.9 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-CvitJUGk.js 1.95 MB 1.95 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-Ds3gPtNh.js 2.08 MB 2.08 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-WJL3cqV8.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-E9hBZNUh.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js 420 kB 420 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 5.25 MB (baseline 5.25 MB) • 🔴 +13 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SubscriptionRequiredDialogContent-BTTz5_8s.js (new) — 29.3 kB 🔴 +29.3 kB 🔴 +6.51 kB 🔴 +5.64 kB
assets/SubscriptionRequiredDialogContent-M_A-XXYH.js (removed) 29.3 kB — 🟢 -29.3 kB 🟢 -6.51 kB 🟢 -5.65 kB
assets/WidgetRecordAudio-BUalKIus.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.23 kB 🔴 +4.63 kB
assets/WidgetRecordAudio-CwSw9T8i.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.23 kB 🟢 -4.63 kB
assets/AudioPreviewPlayer-BfhY4Rdb.js (removed) 13.3 kB — 🟢 -13.3 kB 🟢 -3.35 kB 🟢 -3 kB
assets/AudioPreviewPlayer-CCf5DvbU.js (new) — 13.3 kB 🔴 +13.3 kB 🔴 +3.35 kB 🔴 +3 kB
assets/ValueControlPopover--30-qUS7.js (new) — 5.49 kB 🔴 +5.49 kB 🔴 +1.71 kB 🔴 +1.52 kB
assets/ValueControlPopover-DgkKN2gJ.js (removed) 5.49 kB — 🟢 -5.49 kB 🟢 -1.71 kB 🟢 -1.52 kB
assets/WidgetGalleria-tA5xhXQt.js (removed) 4.1 kB — 🟢 -4.1 kB 🟢 -1.45 kB 🟢 -1.3 kB
assets/WidgetGalleria-TMf6PCcH.js (new) — 4.1 kB 🔴 +4.1 kB 🔴 +1.45 kB 🔴 +1.3 kB
assets/WidgetColorPicker-B8T8e_2V.js (removed) 3.41 kB — 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.24 kB
assets/WidgetColorPicker-X3HHXJAz.js (new) — 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.24 kB
assets/WidgetTextarea-CUECeshA.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.21 kB 🔴 +1.08 kB
assets/WidgetTextarea-jQGFybBJ.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.21 kB 🟢 -1.07 kB
assets/WidgetMarkdown-BRG4jF_Z.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.13 kB
assets/WidgetMarkdown-CHrzUGG8.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.28 kB 🟢 -1.12 kB
assets/WidgetAudioUI-BJnxSGiV.js (removed) 2.89 kB — 🟢 -2.89 kB 🟢 -1.17 kB 🟢 -1.06 kB
assets/WidgetAudioUI-DvczL8Jo.js (new) — 2.89 kB 🔴 +2.89 kB 🔴 +1.17 kB 🔴 +1.06 kB
assets/WidgetToggleSwitch-B43OFr4h.js (new) — 2.66 kB 🔴 +2.66 kB 🔴 +1.13 kB 🔴 +1.03 kB
assets/WidgetToggleSwitch-CcCsa_34.js (removed) 2.66 kB — 🟢 -2.66 kB 🟢 -1.13 kB 🟢 -1.02 kB
assets/WidgetInputText-BinI61se.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +919 B 🔴 +858 B
assets/WidgetInputText-on8Nn6nP.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -919 B 🟢 -857 B
assets/Media3DTop--7xua3zf.js (removed) 1.49 kB — 🟢 -1.49 kB 🟢 -764 B 🟢 -650 B
assets/Media3DTop-BmigghOB.js (new) — 1.49 kB 🔴 +1.49 kB 🔴 +764 B 🔴 +652 B
assets/WidgetSelect-CDmMaAFg.js (new) — 733 B 🔴 +733 B 🔴 +359 B 🔴 +324 B
assets/WidgetSelect-ElD4CR_k.js (removed) 733 B — 🟢 -733 B 🟢 -360 B 🟢 -326 B
assets/WidgetInputNumber-tf4wLdeP.js (new) — 673 B 🔴 +673 B 🔴 +346 B 🔴 +290 B
assets/WidgetInputNumber-Xrhxy1o3.js (removed) 673 B — 🟢 -673 B 🟢 -347 B 🟢 -287 B
assets/Load3D-DCkNd1eN.js (removed) 424 B — 🟢 -424 B 🟢 -266 B 🟢 -223 B
assets/Load3D-Q2GsKRQN.js (new) — 424 B 🔴 +424 B 🔴 +268 B 🔴 +222 B
assets/WidgetLegacy-_xb7howl.js (removed) 364 B — 🟢 -364 B 🟢 -238 B 🟢 -192 B
assets/WidgetLegacy-D7BvbUdY.js (new) — 364 B 🔴 +364 B 🔴 +238 B 🔴 +193 B
assets/commands-7wafkPd1.js 15.6 kB 15.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-B3CjBnJe.js 14.6 kB 14.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bbu2TJPy.js 18.1 kB 18.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BeJss6Df.js 16.9 kB 16.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C4khqsmz.js 15.6 kB 15.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CDQ7KnIn.js 16.4 kB 16.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CtjMsXHh.js 15.4 kB 15.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CW_l758_.js 16.1 kB 16.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DbX4HUlI.js 15.6 kB 15.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DiGLEtFT.js 16.9 kB 16.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-vRVJOWju.js 14.8 kB 14.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B_h9YBFl.js 129 kB 129 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BO2lyoih.js 94.2 kB 94.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BWknJp3D.js 133 kB 133 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C49hGWeZ.js 107 kB 107 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CgivmeTy.js 110 kB 110 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-D_QQCDTL.js 149 kB 149 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-dbu9MIPO.js 123 kB 123 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DhgCCEQx.js 113 kB 113 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DpPNoJth.js 106 kB 106 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-kIdEUfEK.js 94.9 kB 94.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-xSVehrCG.js 108 kB 108 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-DIQlZoPQ.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-C3CvQRZ8.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-euoHxxM5.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-B-XzzBeS.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BGwoeek4.js 329 kB 329 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-C6xl5-mL.js 358 kB 358 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CRZGOJB7.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D8-Yzlzh.js 289 kB 289 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Du8VrAwA.js 320 kB 320 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-jjlLVrIs.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-JQwk1kgy.js 292 kB 292 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-JuuXdMpv.js 391 kB 391 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-l2Y20bod.js 314 kB 314 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-VLMdhOwo.js 357 kB 357 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/OBJLoader2WorkerModule-DTMpvldF.js 109 kB 109 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-515bxB6A.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-DOYclIRS.js 3.21 kB 3.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 16 added / 16 removed

@simula-r
Copy link
Contributor Author

simula-r commented Jan 13, 2026 •
edited
Loading

Test failure is unrelated to this PR. and was introduced in #7852

viva-jinyi
viva-jinyi approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@viva-jinyi viva-jinyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simula-r simula-r added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.36 Backport PRs for cloud 1.36 labels Jan 13, 2026
@simula-r simula-r merged commit 3377844 into main Jan 13, 2026
41 of 42 checks passed
@simula-r simula-r deleted the fix/top-up-trigger-billing-settings branch January 13, 2026 04:50
github-actions bot pushed a commit that referenced this pull request Jan 13, 2026
@simula-r @github-actions
feat: local/legacy settings dialog fix (#7990)
47b290c 
## Summary

Fix the issue where local/desktop users would top up and then see the
settings homepage dialog instead of the credits tab.

## Changes

- **What**: useSubscription.ts, TopUpCreditsDialogContent.vue,
SubscriptionRequiredDialogContent.vue
- **Breaking**: <!-- Any breaking changes (if none, remove this line)
-->
- **Dependencies**: <!-- New dependencies (if none, remove this line)
-->

## Screenshots (if applicable)

Showing this screen after topping up on local/desktop:
<img width="789" height="752" alt="image"
src="https://github.com/user-attachments/assets/ea92b30b-5c3b-412a-acbe-1b0893621e53"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7990-feat-local-legacy-settings-dialog-fix-2e76d73d365081c7b1e1f96a24745e7b)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot mentioned this pull request Jan 13, 2026
Merged
@comfy-pr-bot
Copy link
Member

comfy-pr-bot commented Jan 13, 2026

@simula-r Successfully backported to #8004

@github-actions github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jan 13, 2026
christian-byrne pushed a commit that referenced this pull request Jan 13, 2026
@comfy-pr-bot @simula-r
[backport cloud/1.36] feat: local/legacy settings dialog fix (#8004)
99f5b36 
Backport of #7990 to `cloud/1.36`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8004-backport-cloud-1-36-feat-local-legacy-settings-dialog-fix-2e76d73d3650814398aff135890ee1cb)
by [Unito](https://www.unito.io)

Co-authored-by: Simula_r <[email protected]>
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.37 Backport PRs for cloud 1.37 and removed cloud/1.36 Backport PRs for cloud 1.36 labels Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

@simula-r Commit 337784440890f5b8ea09489f13daa18c2aeebfb4 already exists on branch cloud/1.37. No backport needed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

@simula-r Commit 337784440890f5b8ea09489f13daa18c2aeebfb4 already exists on branch cloud/1.37. No backport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viva-jinyi viva-jinyi viva-jinyi approved these changes

Assignees

No one assigned

Labels

cloud/1.37 Backport PRs for cloud 1.37 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simula-r @comfy-pr-bot @viva-jinyi @christian-byrne