-
Notifications
You must be signed in to change notification settings - Fork 492
fix: prevent confirm dialog buttons from being unreachable on mobile with long text #8746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
7
commits into
main
Choose a base branch
from
fix/mobile/confirm-dialog-textbreak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e160cb7
fix: prevent confirm dialog buttons from being unreachable on mobile …
christian-byrne 6dfffa3
fix: address review - replace style block with Tailwind, type test pr…
christian-byrne 22ab139
[automated] Apply ESLint and Oxfmt fixes
actions-user 638063b
fix: constrain confirm dialog height to keep buttons in viewport on m…
christian-byrne 9b89c9c
fix: constrain global dialog max-height to viewport for mobile overflow
christian-byrne 6d3666c
[automated] Apply ESLint and Oxfmt fixes
actions-user 7e4d35b
fix: apply max-width directly to global-dialog root element
christian-byrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { expect } from '@playwright/test' | ||
|
|
||
| import { comfyPageFixture as test } from '../fixtures/ComfyPage' | ||
|
|
||
| test.describe('Confirm dialog text wrapping', { tag: ['@mobile'] }, () => { | ||
| test('@mobile confirm dialog buttons are visible with long unbreakable text', async ({ | ||
| comfyPage | ||
| }) => { | ||
| const longFilename = 'workflow_checkpoint_' + 'a'.repeat(200) + '.json' | ||
|
|
||
| await comfyPage.page.evaluate((msg) => { | ||
| window | ||
| .app!.extensionManager.dialog.confirm({ | ||
| title: 'Confirm', | ||
| type: 'default', | ||
| message: msg | ||
| }) | ||
| .catch(() => {}) | ||
| }, longFilename) | ||
|
|
||
| const dialog = comfyPage.page.getByRole('dialog') | ||
| await expect(dialog).toBeVisible() | ||
|
|
||
| const confirmButton = dialog.getByRole('button', { name: 'Confirm' }) | ||
| await expect(confirmButton).toBeVisible() | ||
| await expect(confirmButton).toBeInViewport() | ||
|
|
||
| const cancelButton = dialog.getByRole('button', { name: 'Cancel' }) | ||
| await expect(cancelButton).toBeVisible() | ||
| await expect(cancelButton).toBeInViewport() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
src/components/dialog/content/ConfirmationDialogContent.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { mount } from '@vue/test-utils' | ||
| import { createPinia, setActivePinia } from 'pinia' | ||
| import PrimeVue from 'primevue/config' | ||
| import { beforeEach, describe, expect, it, vi } from 'vitest' | ||
| import type { ComponentProps } from 'vue-component-type-helpers' | ||
| import { createI18n } from 'vue-i18n' | ||
|
|
||
| import ConfirmationDialogContent from './ConfirmationDialogContent.vue' | ||
|
|
||
| type Props = ComponentProps<typeof ConfirmationDialogContent> | ||
|
|
||
| const i18n = createI18n({ | ||
| legacy: false, | ||
| locale: 'en', | ||
| messages: { en: {} }, | ||
| missingWarn: false, | ||
| fallbackWarn: false | ||
| }) | ||
|
|
||
| describe('ConfirmationDialogContent', () => { | ||
| beforeEach(() => { | ||
| setActivePinia(createPinia()) | ||
| }) | ||
|
|
||
| function mountComponent(props: Partial<Props> = {}) { | ||
| return mount(ConfirmationDialogContent, { | ||
| global: { | ||
| plugins: [PrimeVue, i18n] | ||
| }, | ||
| props: { | ||
| message: 'Test message', | ||
| type: 'default', | ||
| onConfirm: vi.fn(), | ||
| ...props | ||
| } as Props | ||
| }) | ||
| } | ||
|
|
||
| it('renders long messages without breaking layout', () => { | ||
| const longFilename = | ||
| 'workflow_checkpoint_' + 'a'.repeat(200) + '.safetensors' | ||
| const wrapper = mountComponent({ message: longFilename }) | ||
| expect(wrapper.text()).toContain(longFilename) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Comfy-Org/ComfyUI_frontend
Length of output: 4784
🏁 Script executed:
rg "overflow-y-auto" src/components --type vue -A 2 -B 2Repository: Comfy-Org/ComfyUI_frontend
Length of output: 97
🏁 Script executed:
rg "overflow-y-auto" src/components -A 2 -B 2Repository: Comfy-Org/ComfyUI_frontend
Length of output: 9356
Add
min-h-0to ensure the scroll container shrinks reliably in flex columns.Without
min-h-0, flex children withoverflow-y-automay not shrink below their content size in all browsers, preventing the scrollable area from functioning properly and allowing long content to push the action buttons off-screen. This pattern is consistently applied throughout the codebase (e.g.,BaseModalLayout.vue,MembersPanelContent.vue).✅ Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents